Date: Sun, 17 Sep 2000 11:54:44 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: arch@freebsd.org Subject: Re: cvs commit: src/sys/pci if_fxp.c if_fxpvar.h (fwd) Message-ID: <Pine.BSF.4.21.0009171154180.96334-100000@beppo.feral.com>
next in thread | raw e-mail | index | archive | help
[ moved to -arch where it should be ] > > [ moved to -developers ] > > I'm not sure you need to maintain NetBSD compatibility here. I don't believe > that NetBSD really cares what happens to the FreeBSD. The if_fxp driver in > NetBSD has been beat on substantially for a very very long time w/o in > back-sync to FreeBSD. In fact, it's not split into MI/MD pieces, etc. [ too much flu still- let's try this one again ] I'm not sure you need to maintain NetBSD compatibility here. I don't believe that NetBSD really cares what happens to the FreeBSD version. The if_fxp driver in NetBSD has been beat on substantially for a very very long time w/o in any back-sync to FreeBSD. In fact, it's been split into MI/MD pieces, etc. so that it's even hard to track any shared history with FreeBSD. > > I'd suggest that unless there is an author actively maintaining it in both > organizations and unless they're done as cleanly as (forgive my blushes, but > this is something I claim I know a fair amount about) as the Qlogic driver > (for SCSI HBAs) or the wx driver (for NICs), clearing out the NetBSD bits > would be a Good Thing To Do(tm) in order to increase maintainability on it. > > The same thing applies to the de driver also- which is almost deprecated in > NetBSD anyway. > > I thought dg was maintainer for fxp- should it be his call? > > On Sun, 17 Sep 2000, Chuck Paterson wrote: > > > cp 2000/09/17 06:26:26 PDT > > > > Modified files: > > sys/pci if_fxp.c if_fxpvar.h > > Log: > > Add locking to make able to run without the Giant lock being held. This > > is enabling as all entries are still called with Giant being held. > > Maintaining compatability with NetBSD makes what should be very simple > > kinda ugly. > > > > Reviewed by: Jason Evans > > > > Revision Changes Path > > 1.86 +45 -18 src/sys/pci/if_fxp.c > > 1.11 +8 -1 src/sys/pci/if_fxpvar.h > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009171154180.96334-100000>