From owner-cvs-src@FreeBSD.ORG Fri May 30 04:04:16 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEA0337B401; Fri, 30 May 2003 04:04:16 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88E1943F93; Fri, 30 May 2003 04:04:15 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id C7B94530E; Fri, 30 May 2003 13:04:13 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Robert Watson References: <200305292251.h4TMprW5068851@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Fri, 30 May 2003 13:04:12 +0200 In-Reply-To: <200305292251.h4TMprW5068851@repoman.freebsd.org> (Robert Watson's message of "Thu, 29 May 2003 15:51:53 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.1001 (Gnus v5.10.1) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/security/mac_biba mac_biba.c src/sys/security/mac_mls mac_mls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2003 11:04:17 -0000 Robert Watson writes: > Modified files: > sys/security/mac_biba mac_biba.c > sys/security/mac_mls mac_mls.c > Log: > Use strsep() in preference to manual string parsing for Biba and MLS > label internalization. Use sensible variable names. Include comments. > Doesn't fix any known bugs, but may fix unknown ones. This breaks LINT: /vol/vol0/users/des/tinderbox/CURRENT/alpha/alpha/src/sys/security/mac_mls/mac_mls.c: In function `mac_mls_parse': /vol/vol0/users/des/tinderbox/CURRENT/alpha/alpha/src/sys/security/mac_mls/mac_mls.c:675: warning: unused variable `range' /vol/vol0/users/des/tinderbox/CURRENT/alpha/alpha/src/sys/security/mac_mls/mac_mls.c:675: warning: unused variable `rangeend' *** Error code 1 DES -- Dag-Erling Smorgrav - des@ofug.org