Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Sep 2016 20:21:16 +0000 (GMT)
From:      jenkins-admin@FreeBSD.org
To:        kib@FreeBSD.org, dim@FreeBSD.org, andrew@FreeBSD.org,  jenkins-admin@FreeBSD.org, freebsd-stable@FreeBSD.org,  freebsd-i386@FreeBSD.org
Subject:   FreeBSD_STABLE_11-i386 - Build #120 - Fixed
Message-ID:  <189869325.2.1473279680248.JavaMail.jenkins@jenkins-9.freebsd.org>
In-Reply-To: <486782648.47.1473220970030.JavaMail.jenkins@jenkins-9.freebsd.org>
References:  <486782648.47.1473220970030.JavaMail.jenkins@jenkins-9.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
FreeBSD_STABLE_11-i386 - Build #120 - Fixed:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_STABLE_11-i386/120/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_STABLE_11-i386/120/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_STABLE_11-i386/120/console

Change summaries:

305557 by dim:
MFC r305388:

With clang 3.9.0, compiling uplcom results in the following warnings:

sys/dev/usb/serial/uplcom.c:543:29: error: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 192 to -64 [-Werror,-Wconstant-conversion]
        if (uplcom_pl2303_do(udev, UT_READ_VENDOR_DEVICE, UPLCOM_SET_REQUEST, 0x8484, 0, 1)
            ~~~~~~~~~~~~~~~~       ^~~~~~~~~~~~~~~~~~~~~
sys/dev/usb/usb.h:179:53: note: expanded from macro 'UT_READ_VENDOR_DEVICE'
#define UT_READ_VENDOR_DEVICE   (UT_READ  | UT_VENDOR | UT_DEVICE)
                                 ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

This is because UT_READ is 0x80, so the int8_t argument is wrapped to a
negative value.  Fix this by using uint8_t instead.

Reviewed by:	imp, hselasky
Differential Revision: https://reviews.freebsd.org/D7776

305556 by dim:
MFC r305360:

With clang 3.9.0, compiling cxgb results in the following warning:

sys/dev/cxgb/cxgb_sge.c:2873:44: error: implicit conversion from 'int'
to 'char' changes value from 128 to -128 [-Werror,-Wconstant-conversion]
                        *mtod(m, char *) = CPL_ASYNC_NOTIF;
                                         ~ ^~~~~~~~~~~~~~~

This is because CPL_ASYNC_NOTIF is 0x80, so the plain char argument is
wrapped to a negative value.  Fix this by using uint8_t instead.

Reviewed by:	np
Differential Revision: https://reviews.freebsd.org/D7772

305555 by dim:
MFC r305345:

With clang 3.9.0, compiling ppbus(4) results in the following warnings:

sys/dev/ppbus/ppb_1284.c:296:46: error: implicit conversion from 'int'
to 'char' changes value from 144 to -112 [-Werror,-Wconstant-conversion]
	if ((error = do_peripheral_wait(bus, SELECT | nBUSY, 0))) {
		     ~~~~~~~~~~~~~~~~~~      ~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:785:48: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
		if (do_1284_wait(bus, nACK | SELECT | PERROR | nBUSY,
		    ~~~~~~~~~~~~      ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:786:29: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
					nACK | SELECT | PERROR | nBUSY)) {
					~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

This is because nBUSY is 0x80, so the plain char argument is wrapped to
a negative value.  Fix this in a minimal fashion, by using uint8_t in a
few places.

Reviewed by:	emaste
Differential Revision: https://reviews.freebsd.org/D7771

305554 by dim:
MFC r305344:

Define drmP.h's __OS_HAS_AGP and __OS_HAS_MTRR macros in a defined and
portable way.

Reviewed by:	dumbbell
Differential Revision: https://reviews.freebsd.org/D7770

305553 by dim:
MFC r305085:

Fix warnings in tnftp about invalid constant conversions, e.g.:

contrib/tnftp/src/ftp.c:2067:11: error: implicit conversion from 'int'
to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conversion]
        buf[0] = IAC;
               ~ ^~~
/usr/include/arpa/telnet.h:39:13: note: expanded from macro 'IAC'
#define IAC     255             /* interpret as command: */
                ^~~
contrib/tnftp/src/ftp.c:2068:11: error: implicit conversion from 'int'
to 'char' changes value from 244 to -12 [-Werror,-Wconstant-conversion]
        buf[1] = IP;
               ~ ^~
/usr/include/arpa/telnet.h:50:12: note: expanded from macro 'IP'
#define IP      244             /* interrupt process--permanently */
                ^~~

Use an unsigned char buffer instead.

305552 by dim:
MFC r305077:

Squelch clang 3.9.0 warnings about BASE (which is 32768) being converted
to -32768 when it is used as an argument to mp_itom(), in both libtelnet
and newkey.  This code has been wrong since r26238 (!), so after almost
20 years it is rather useless to try to correct it.

MFC r305086:

Fix warnings in telnet about invalid constant conversions, e.g.:

contrib/telnet/telnet/commands.c:2914:13: error: implicit conversion
from 'int' to 'char' changes value from 137 to -119
[-Werror,-Wconstant-conversion]
		*lsrp++ = IPOPT_SSRR;
			~ ^~~~~~~~~~
/usr/include/netinet/ip.h:152:21: note: expanded from macro 'IPOPT_SSRR'
#define IPOPT_SSRR              137             /* strict source route */
				^~~
contrib/telnet/telnet/commands.c:2916:13: error: implicit conversion
from 'int' to 'char' changes value from 131 to -125
[-Werror,-Wconstant-conversion]
		*lsrp++ = IPOPT_LSRR;
			~ ^~~~~~~~~~
/usr/include/netinet/ip.h:148:21: note: expanded from macro 'IPOPT_LSRR'
#define IPOPT_LSRR              131             /* loose source route */
				^~~

Use unsigned char buffers instead.

305550 by dim:
MFC r305218:

Pull in r277331 from upstream llvm trunk (by Diana Picus):

  [AArch64] Return the correct size for TLSDESC_CALLSEQ

  The branch relaxation pass is computing the wrong offsets because it assumes
  TLSDESC_CALLSEQ eats up 4 bytes, when in fact it is lowered to an instruction
  sequence taking up 16 bytes. This can become a problem in huge files with lots
  of TLS accesses, as it may slowly move branch targets out of the range computed
  by the branch relaxation pass.

  Fixes PR24234 https://llvm.org/bugs/show_bug.cgi?id=24234

  Differential Revision: https://reviews.llvm.org/D22870

This fixes "error in backend: fixup value out of range" when compiling
the misc/talkfilters port for AArch64.

Reported by:	sbruno
PR:		201762

305547 by dim:
MFC r304920:

In ncurses baudrate definitions, avoid warnings about implicit
conversions from int to short changing the values.  This applies to
B38400 and higher, since their values do not fit into a short.

However, since the wrapped values are still unique, and they only serve
as keys, there is no problem in adding a cast to silence the warnings.
This also avoids changing the ABI, which would happen if we changed
NCURSES_OSPEED to int.

Discussed with:	Thomas Dickey

305543 by andrew:
MFC 303299, 303475:
 - Enable the generic OHCI driver on arm64
 - Add a generic EHCI USB driver based on the Allwinner A10 driver

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305542 by andrew:
MFC 303592:
Extract the common parts of pmap_kenter_device to a new function

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305540 by andrew:
MFC 303585, 303587:
 - Relax the barriers around a TLB invalidation
 - Fix the comment above pmap_invalidate_page

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305538 by kib:
MFC r304279:
By default, allow all to read the HPET registers pages.  At the same
time, by, by default disallow writes to the mmaped HPET pages.

305537 by andrew:
MFC 304801:
  Don't set *dev in the zfs root case, it may be NULL and will correctly be
  set later in the function. This fixes a potential NULL pointer dereference
  found on arm64.

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305534 by andrew:
MFC 303594, 303610:
 Add more AArch64 special register macros

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305533 by andrew:
MFC 304625:
 Fix the arm64 non-SMP build.

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305532 by andrew:
MFC 303307, 303308, 303309 clean up the arm64 MP code:
 - Rework how we number CPUs on arm64 to try and keep clusters together.
 - Fix a typo in a string in a KASSERT to sanity check the CPU IDs.
 - Remove an unused variable.

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305531 by andrew:
MFC 303661:
 Remove trailing whitespace from the arm64 pmap

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation

305530 by andrew:
MFC 304140:
 Add the ARMv8.1 identification registers to the list we print when booting.

Sponsored by:	ABT Systems Ltd

305529 by andrew:
MFC 302849, 302851, 302896 GICv3 improvements:
 - Move internal data structures out of the common header file
 - Remove unused data structures and macros
 - Add us_print_child to the GICv3 driver

Obtained from:	ABT Systems Ltd
Sponsored by:	The FreeBSD Foundation




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?189869325.2.1473279680248.JavaMail.jenkins>