From owner-freebsd-current@FreeBSD.ORG Sat Jan 3 17:32:46 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6538F106564A; Sat, 3 Jan 2009 17:32:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout012.mac.com (asmtpout012.mac.com [17.148.16.87]) by mx1.freebsd.org (Postfix) with ESMTP id 4E6388FC0C; Sat, 3 Jan 2009 17:32:46 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from [192.168.1.96] (75-101-29-67.dsl.static.sonic.net [75.101.29.67]) by asmtp012.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0KCW008M4OQK8A40@asmtp012.mac.com>; Sat, 03 Jan 2009 09:32:46 -0800 (PST) Message-id: <440945C2-252E-489A-902E-A499753A5EF8@mac.com> From: Marcel Moolenaar To: "M. Warner Losh" In-reply-to: <20090102.231410.-2001109684.imp@bsdimp.com> Date: Sat, 03 Jan 2009 09:32:44 -0800 References: <20090102091334.GA41230@dragon.NUXI.org> <20090102.114757.-924277930.imp@bsdimp.com> <20090103033543.GB77475@dragon.NUXI.org> <20090102.231410.-2001109684.imp@bsdimp.com> X-Mailer: Apple Mail (2.930.3) Cc: bsam@ipt.ru, freebsd-current@freebsd.org, fbsdlist@src.cx Subject: Re: gjournal is not automounted any more X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jan 2009 17:32:46 -0000 On Jan 2, 2009, at 10:14 PM, M. Warner Losh wrote: > In message: <20090103033543.GB77475@dragon.NUXI.org> > "David O'Brien" writes: > : On Fri, Jan 02, 2009 at 11:47:57AM -0700, M. Warner Losh wrote: > : > In message: <20090102091334.GA41230@dragon.NUXI.org> > : > "David O'Brien" writes: > : > : Before 'fsck' would read the lable for the FS type. That has > changed and > : > : thus you cannot just 'fsck /dev/ad1s1d' anymore. So the FS > type in fstab > : > : must be accurate. > : > > : > Why did that change? I routinely have disks that aren't in my > : > /etc/fstab that I mount and this is a pain in the backside. > : > : Due to r186240 which: > : Make gpart the default partitioning class on all platforms. > : > : Seems GEOM_PART_BSD does not like labels that GEOM_BSD did. > > Then why the change? Shouldn't we make it like them for > compatibility? David's statement is incorrect. They like the same labels for all practical purposes. The problem at hand here is that fsck(8) & newfs(8) ask of GEOM_BSD what the partition type is. This means 2 things: 1. Any platform that doesn't use the BSD disklabel by default needs to have a proper /etc/fstab and is not behaving the same as i386. 2. Switching to GPT as the default partitioning scheme yields the same problem. As I said in an email to arch@, it's good to query the partition type to determine what to do when more specific information is missing (running fsck(8) vs fsck_ffs(8)). But it wasn't something that was there at the switchover point. FYI, -- Marcel Moolenaar xcllnt@mac.com