Date: Fri, 27 Mar 2015 13:11:07 +0100 From: Alexandre Martins <alexandre.martins@stormshield.eu> To: freebsd-current@freebsd.org Cc: "Andrey V. Elsukov" <bu7cher@yandex.ru> Subject: Re: Mbuf leak in if_lagg.c Message-ID: <3503024.JPjPSR4hce@pc-alex> In-Reply-To: <551467C9.3000103@yandex.ru> References: <1708955.mQ2X6OUmTD@pc-alex> <55146124.2070501@yandex.ru> <551467C9.3000103@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1917558.jPYzOGWkLN Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Le jeudi 26 mars 2015, 23:10:49 Andrey V. Elsukov a =E9crit : > On 26.03.2015 22:42, Andrey V. Elsukov wrote: > >> If lp_detaching is non 0, the mbuf pointer is set to NULL without = m_freem > >> it. > >>=20 > >> Can you look at this ? > >=20 > > Hi, > >=20 > > what you thing about this patch? > > lp_detaching can be non zero in case of parent interface departure.= > > So I don't see the reason to call ETHER_BPF_MTAP() in this case. >=20 > Now I see the reason - to capture all received packets before interfa= ce > departure. New is attached. Sounds good for me :) =2D-=20 Alexandre Martins STORMSHIELD --nextPart1917558.jPYzOGWkLN Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIIhDCCBIYw ggJuoAMCAQICBQDbzPDtMA0GCSqGSIb3DQEBCwUAMEgxCzAJBgNVBAYTAkZSMRQwEgYDVQQKDAtT VE9STVNISUVMRDEjMCEGA1UEAwwaU3Rvcm1zaGllbGQgUm9vdCBBdXRob3JpdHkwHhcNMTQwOTA0 MTUwNzEwWhcNMjQwOTAxMTUwNzEwWjBJMQswCQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElF TEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVzZXJzIEF1dGhvcml0eTCCASIwDQYJKoZIhvcNAQEB BQADggEPADCCAQoCggEBAMKHBaAL/pVYovuOBYjd4DaxW9F07C4dxexEABdVZ2UwLTKCDu7jkTvw aECel2XxBsi7vH9DbM6roq22ynAMQiOSgwtNmeAsuUaNglk9+5KgLqGX1Hu9F3l/wWG7e/TFD/u/ MpjPgLzfogYKuTfWCas87QfR/GTLEIx+GhNPO57ehdbUiyZDAKs4867ZjzZAA0OFuJ9YuMhYl62e PnxhEpHzYoGzcWVurG2nSaL34izAy8IJFKhP45EHvcKXpRG3tCbsFwP6qeQn27CVQL3h0iVPaFfj Jtj/D+ywDXsTDjXx+DJEJZBfOCNmBn9dRzDZY/10iCADs+D5z/F5E4kfXO8CAwEAAaN2MHQwHQYD VR0OBBYEFKFthGyigIUFfHx1dYA0wRNbl9eBMB8GA1UdIwQYMBaAFLhCqfpnRPB/02GM7KXHUK60 veyjMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQDAgEGMBEGCWCGSAGG+EIBAQQEAwIBBjAN BgkqhkiG9w0BAQsFAAOCAgEAToL3OS3Ynp0+bYotvNFLqsEhhk0WLRfn2Dd6RDZJzhRayr4Hcvzq PnGdBJGcgz8MpXX5DZQdtT+qyHhy2jZ/BNXpX5onTtW79skTWsA3gAjhXbrK1/tWgFwGNVkmrykc 4yn8bZ5AfsXXGrOaXrwOkqS7rppRqWRwL0gzzabsBbdgDK8OhgQByG/irIvyqFUsunos2u7xk6Ew QuFktaXi6XD9IUMyFwFLojjALqJyPvUwsZKuvrW8yS0x3BD4IYVDnPkltrEzrVWDMprLz6CXD7FN umeK2sN+GTMezZ93A466ve+02c2yt0FaJg+x4naThUYPui/mQhNBlySZnIX9X4iv/9qAlAZW7CEN kJeBc6+uN74Utinu1D2mBK8tuW6HUD7LB/IecUjifq1nL1IPcwgOBZHgrAUszVCa3c1Bvfa2Sr1W bSNRxBcV9udYosD2SvDebw2YKqEvk/Ol856Bg5zRAlZ8xBqbF5bFcwuTq4qKxL//5Wp+kJrknHne 370Oag3X6hviM6ms9pfq18EGvl2NqHbLM8aMcQHnZWBZfEgX2UIzbPtDD7MVvY8h015KMiQ0QWD/ WisoABrmBBcBDKc3YnsT5ot/ZcuEdxLS/73KiKw8TD35NvkXW5CH6DNgPklRRhxhadydfyA/yTpf 4XmZD/zUig0v8h6PEmDL8ugwggP2MIIC3qADAgECAgUAhSjIwzANBgkqhkiG9w0BAQUFADBJMQsw CQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElFTEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVz ZXJzIEF1dGhvcml0eTAeFw0xNDA5MDQxNTEwMzhaFw0xNTA5MDQxNTEwMzhaMHAxCzAJBgNVBAYT AkZSMRQwEgYDVQQKDAtTVE9STVNISUVMRDEaMBgGA1UEAwwRQWxleGFuZHJlIE1BUlRJTlMxLzAt BgkqhkiG9w0BCQEWIGFsZXhhbmRyZS5tYXJ0aW5zQHN0b3Jtc2hpZWxkLmV1MIIBIjANBgkqhkiG 9w0BAQEFAAOCAQ8AMIIBCgKCAQEAva7AtO0nbBUoYsRPeAP+85Lv4zx5bPdpxLuQVJmFJL6VDH28 Qxoxlq0j/3HGdfFR2sFe+utPledu6F79SCJDYRQ5ZQuS+TFgyvVzCSuVqpw6z0LQdTh4pouCh71B Bb8RSUXX2zx7Fu5IlSpLjGIf0prk1xrz/YyHJLQo2mSusnogi6hF2GsEVViUZtemK+uPqVToJ5oR AAJ4mU/Xl3aCOd7O3UzNT3T0clrfpNHKrcWcyqgE6g/gY/7NiJESRov3De8xzcczLxJFO51ODlaw y8yT1AHyWIDEkcbgX1Gk4s1ImXQDoq6pQEq2O5cIr59GlSd/YBq36Av6J3LGcmVnQwIDAQABo4G9 MIG6MB0GA1UdDgQWBBTL/0iutSuRsFLRxja4yiLlnMg2rTAfBgNVHSMEGDAWgBShbYRsooCFBXx8 dXWANMETW5fXgTAJBgNVHRMEAjAAMA4GA1UdDwEB/wQEAwID6DArBgNVHREEJDAigSBhbGV4YW5k cmUubWFydGluc0BzdG9ybXNoaWVsZC5ldTARBglghkgBhvhCAQEEBAMCBLAwHQYDVR0lBBYwFAYI KwYBBQUHAwQGCCsGAQUFBwMCMA0GCSqGSIb3DQEBBQUAA4IBAQBHvjAZNyBp1pfsgV5R2oECDTsU vzfyvrj1CVTbOCXtg036DS7Tms7oybwsxUv6kQg9iq5eAklfyuz53VkL9IArm/iWn9QwecxANeMq k3Lc1LIMPhqqg6WZDze1G2PfYlwBkputKyQlhifQ8Xx6wJ+avt1lum5P1EFcQfG6zreyOxfai99a QcAxP1Ry3nXQMbUzP5UZkK0+PhYvy9mTv4b1vPWxeUMMXSO1TPXN1IkuPzzvR86MDHFO17l/aqJV Mr6Ea2A/deI7JilI48fb8jTsAaxBWL5RwrreXLXBjKDsEYzrANB4Kn/uQzkjnRM1NVRS+SMro3tk hzfdSmUFXs5tMYICAzCCAf8CAQEwUjBJMQswCQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElF TEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVzZXJzIEF1dGhvcml0eQIFAIUoyMMwCQYFKw4DAhoF AKCBhzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xNTAzMjcxMjEx MDdaMCMGCSqGSIb3DQEJBDEWBBSiTTYgubwCzF8FiWCcRD8aK3y0MDAoBgkqhkiG9w0BCQ8xGzAZ MAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzANBgkqhkiG9w0BAQEFAASCAQCW3Ve4zdn6z3fYoBl9 hL+TtptCIuE8Vrae/6u9enq4zb9v7G4N4oRb8wkKLRAcGq4plpBks7hg1au1qgSwnov5AtnjtuVx 6UFMIsmGhQWtcRieyZrxvH7B2TFHYrMbger7LWgLHzbVxG4e6FD4bJL6DHRZS/aLc20udmOvfCD3 /zJ3cSXBtGy1g/IZ4Yw0aykTzA51iQihZtuOj5zdEuPkRQljLwYVBAwKILOUUChkdVAir9HxaJt8 NaS5hrXagSbTy8dfN9UD4059VF+JJLXiyJFtVBrobIop91GQVkyN5y54epGAAZoZj/4lRsG8u9Mv oD1DeY0L6NNMVDxJ5yHvAAAAAAAA --nextPart1917558.jPYzOGWkLN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3503024.JPjPSR4hce>