From owner-freebsd-arm@FreeBSD.ORG Mon Mar 18 15:37:10 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9BB3BA08 for ; Mon, 18 Mar 2013 15:37:10 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 321D5309 for ; Mon, 18 Mar 2013 15:37:10 +0000 (UTC) Received: by mail-wi0-f175.google.com with SMTP id l13so2819929wie.14 for ; Mon, 18 Mar 2013 08:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=fnpfxG+pWSa+B1YNSNOSjoyNaTEMEAyX67EC6vgejJc=; b=lyOFtZPYXgCwHI/zCXvC1iifXogpSjoh1jnReEqr2J3TahiF9YaCBwGyibzGhP0cdj v46tGU9dVuYd7Id0rAjRzmDpibNWkUqzzDLf82BzX2MmtgNLgaAjU6b0RThrtunxC/0m zYiGqFQIGezJoe5i76YP+c71072NDEi9WUtW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=fnpfxG+pWSa+B1YNSNOSjoyNaTEMEAyX67EC6vgejJc=; b=IRHo7BXeypTzG9IcjAJb3sallKA3MLCx7MXMHgIMNGwx+sRVCf7UmNgf4MOcp7rwtV zaGLqwjGcVSP2IX3gh/gOlW5l7mpmKGps4GsfX1oh3wR/dpayHF/mFgpjWu1/+piRHgM LOcrEBylQX9CtWfMESknsW6Uhx9puNqwFOSAPzllQFamPiqm87YYWcvIz6tdj2olbkbT Xa+8pQ1XzyNZ6B4/xIpbfj49azn7TWF5vJaOSN2AWyMDqAPHwEsuDpyqJY9o+tZ5k4E/ 8ip5bDl+EgSQ4taOJqZsRkyi63YuxCqD4AON2+A/0klLH+RRb68/QAONVv061PgLrGIj cFzA== X-Received: by 10.180.14.233 with SMTP id s9mr17680228wic.25.1363621029231; Mon, 18 Mar 2013 08:37:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.82.74 with HTTP; Mon, 18 Mar 2013 08:36:39 -0700 (PDT) In-Reply-To: <20130318105349.GS3729@plum.flirble.org> References: <20130318220747.29d3fd29@bender> <20130318105349.GS3729@plum.flirble.org> From: Eitan Adler Date: Mon, 18 Mar 2013 11:36:39 -0400 Message-ID: Subject: Re: RFC: Make clang the default compiler on ARM To: Nicholas Clark Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQk2g/9gmPd80Fuk0fge2h+IPALilbqriKP2zi4+cQ6nMF6itYX7ZDknJoh5PDHEgVouR0lK Cc: freebsd-arm@freebsd.org, freebsd-toolchain@freebsd.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2013 15:37:10 -0000 On 18 March 2013 06:53, Nicholas Clark wrote: > On Mon, Mar 18, 2013 at 10:07:47PM +1300, Andrew Turner wrote: >> I would like to make clang the default compiler on ARM using the patch >> at [1]. This only affects little-endian ARM as there is no support for >> big-endian ARM in clang. > >> [1] http://people.freebsd.org/~andrew/clang/arm_clang_default.diff > > I admit that I'm a complete outsider here I'm not sure if I'm qualified to > comment, but in the code in question, the comment above the changed line is > becoming increasingly incorrect, isn't it? I think you are right. Given that the comment duplicates the if statement below, it should probably just be dropped. -- Eitan Adler