Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Apr 2017 22:34:28 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r437456 - in head/devel/glib20: . files
Message-ID:  <20170401203428.mrsi23tcxvwgkg7c@ivaldir.net>
In-Reply-To: <h927-oom7-wny@FreeBSD.org>
References:  <201704011924.v31JOMFm032870@repo.freebsd.org> <h927-oom7-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--buhbctbdmcwh3f3s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 01, 2017 at 10:32:32PM +0200, Jan Beich wrote:
> Baptiste Daroussin <bapt@FreeBSD.org> writes:
>=20
> > Author: bapt
> > Date: Sat Apr  1 19:24:21 2017
> > New Revision: 437456
> > URL: https://svnweb.freebsd.org/changeset/ports/437456
> >
> > Log:
> >   update to 2.52.0
> >   - remove the GDB option and always install the py script, it does not=
 hurt
> >   - remove pathfix as pkgconf now accept the lib/pkgconfig path
> >   - switch to option framework where possible
>=20
>=20
> > +DEBUG_CONFIGURE_ARGS+=3D	--enable-debug=3Dyes \
> > +			--disable-silent-rules
>=20
> --disable-silent-rules is already part of LATE_CONFIGURE_ARGS.

Yeah it was in the update I can just nuke that one
>=20
> > #COLLATION_FIX_CONFIGURE_ENV+=3D	CFLAGS=3D"-D__STDC_ISO_10646__"
>=20
> Passing a variable more than once overrides previous assignments e.g.,
> -fno-strict-aliasing -fstack-protector. Maybe convert to:

It is any commented out, given kwm is the main maintainer and was keep the
comment I kept it (just adapted
>=20
>   COLLATION_FIX_CFLAGS=3D	-D__STDC_ISO_10646__
>=20
> > Added: head/devel/glib20/files/patch-glib_gthread-posix.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/devel/glib20/files/patch-glib_gthread-posix.c	Sat Apr  1 19:24=
:21 2017	(r437456)
> > @@ -0,0 +1,20 @@
> > +--- glib/gthread-posix.c.orig	2014-09-22 15:42:12.000000000 +0200
> > ++++ glib/gthread-posix.c	2014-09-28 09:46:56.659280343 +0200
>=20
> Can you re-apply r437111? The rationale the file was added years ago is
> documented in that bug. And regression tests didn't find new failures
> after removal.

Sure!

--buhbctbdmcwh3f3s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAljgDtIACgkQY4mL3PG3
Plqbiw//UVaEeYaaaTJPwnRx884f8SE7s0WH6uJhqoSlB+JkES6N3Ai6bK/zMISb
uUBPt1etToAADyQrbBxtWlftEOI2uhK/FNwwKTwclQR0F2hezSOgi1OPsa+k3Vd2
2WaYHwPfQhUa0ncOPKffoUJRzIvorpL21Y/4qRIXd2qEEMtBMqzMO19rPph+iOk3
zFiDk+0Z28kotGGqO4R1ZGfCARlL1W2oZVDhhglP/+rxZa5AzEfSsATqlrz7uA2A
XG/SRPRBzBaOA4sLI2GtUVbZHvEShxTFgqpAO8jds+oJKMUMAviXXFhIFxW69YFw
8YDMZpavT1BoTvFCxjkmndjATWZGdZQT+Rtuskvj3qlkOSBRJ8Teeyy7VL8kKCV/
hTNAKwl9k0iRP/hcl82f/xKnHJz2Iyx4E1uNp3CsAKBuyKPWnO4+MuAZVNGbKqqF
m+oeJ0sO55wbfCHx/5IB8lJwVy3cprjeZL89bse7yBePOmOtAWZ4x30Zj8pMUc0Z
qbV5Wbul1Mpgl3Cx1t6EfO0UcIIloKt4PtzJRDazxTz+IcebPAqcq0L9N9gqR79K
NR5IRQNOQPnWe+4HsQDJnBvkWGZmN897lNyhNWwcth7+Ejdyj3s35a0kjysCX8qm
URylOgG4ckZlgpIakaaAlKNPPkPKn268xjK3H1A9wFrXss0IT7U=
=SqKp
-----END PGP SIGNATURE-----

--buhbctbdmcwh3f3s--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170401203428.mrsi23tcxvwgkg7c>