Date: Mon, 11 Mar 2019 12:04:06 -0500 From: Justin Hibbits <chmeeedalf@gmail.com> To: John Baldwin <jhb@FreeBSD.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Justin Hibbits <jhibbits@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190311120406.58a21e1e@titan.knownspace> In-Reply-To: <7e2e2cca-ae57-4ab4-6144-54cd196dce70@FreeBSD.org> References: <201903090318.x293IcLc023548@repo.freebsd.org> <20190309085058.GA60945@FreeBSD.org> <20190310171640.31bb9c54@titan.knownspace> <7e2e2cca-ae57-4ab4-6144-54cd196dce70@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 11 Mar 2019 10:02:00 -0700 John Baldwin <jhb@FreeBSD.org> wrote: > On 3/10/19 3:16 PM, Justin Hibbits wrote: > > On Sat, 9 Mar 2019 08:50:58 +0000 > > Alexey Dokuchaev <danfe@freebsd.org> wrote: > > > >> On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > >>> New Revision: 344960 > >>> URL: https://svnweb.freebsd.org/changeset/base/344960 > >>> > >>> Log: > >>> powerpc: Print trap frame address for fatal traps > >>> > >>> MFC after: 1 week > >>> > >>> Modified: > >>> head/sys/powerpc/powerpc/trap.c > >>> > >>> Modified: head/sys/powerpc/powerpc/trap.c > >>> ============================================================================== > >>> --- head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:15:09 > >>> 2019 (r344959) +++ head/sys/powerpc/powerpc/trap.c > >>> Sat Mar 9 03:18:37 2019 (r344960) @@ -546,6 +546,7 @@ > >>> printtrap(u_int vector, struct trapframe *frame, int i printf(" > >>> current msr = 0x%" PRIxPTR "\n", mfmsr()); printf(" > >>> lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr, > >>> frame->lr - (register_t)(__startkernel - KERNBASE)); > >>> + printf(" frame = %p\n", frame); > >>> printf(" curthread = %p\n", curthread); > >> > >> Some of those are printed with %PRIxPTR, some with %p. Perhaps > >> this inconsistency can be avoided? > >> > >> ./danfe > > > > PRIxPTR is for printing a pointer-like value that's not a pointer. > > The other values printed are of type register_t, not void *. > > Normally in FreeBSD sources we cast it to void * and use %p rather > than the PRI* macros FWIW. > Fair enough. I can add that to my TODO list. I have to fix the msr printing anyway, since the msr itself is not a pointer, but it's printed as such. May as well clean them all up. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190311120406.58a21e1e>