Date: Fri, 11 May 2012 13:46:48 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Mateusz Guzik <mjg@semihalf.com> Cc: svn-src-projects@freebsd.org, Grzegorz Bernacki <gber@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r233072 - projects/nand/sys/kern Message-ID: <20120511104648.GM2358@deviant.kiev.zoral.com.ua> In-Reply-To: <20120510164519.GA13258@pcbsd-2342.semihalf.com> References: <201203170318.q2H3ITdI047893@svn.freebsd.org> <20120317085116.GC1340@garage.freebsd.pl> <20120317161050.GI75778@deviant.kiev.zoral.com.ua> <4FA8FFB9.7090002@freebsd.org> <20120508095631.GV2358@deviant.kiev.zoral.com.ua> <4FA94609.3060306@freebsd.org> <20120510103105.GG2358@deviant.kiev.zoral.com.ua> <4FABC64F.3060502@freebsd.org> <20120510115857.GH2358@deviant.kiev.zoral.com.ua> <20120510164519.GA13258@pcbsd-2342.semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--23eOHpR5vYWIDA3o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 10, 2012 at 06:45:19PM +0200, Mateusz Guzik wrote: > http://people.freebsd.org/~raj/patches/misc/vfs_highdirtybuf.diff >=20 > callbacks are expected to increase flushed counter if they happend to > flush some buffers. I do not think this is right. You need to call a routine when getnewblk() is unable to find a buffer to recycle. As I understand, in your situation with lot of managed buffers, the dirty queue could be just empty. >=20 > Example proof-of-concept (will be cleaned up) change for nandfs: > http://people.freebsd.org/~raj/patches/misc/nandfs_vfs_highdirtybuf.diff >=20 > Does this look reasonable? >=20 > --=20 > Mateusz Guzik <mjg semihalf.com> --23eOHpR5vYWIDA3o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+s7hYACgkQC3+MBN1Mb4i+QACfTBH8z4JVPDHuSaTcwutFQD3S yvYAoNCvUl9fvyGvd5hB+ILx3M4EPKw+ =LqdC -----END PGP SIGNATURE----- --23eOHpR5vYWIDA3o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120511104648.GM2358>