From owner-svn-ports-head@freebsd.org Fri Oct 4 09:48:38 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A2362129A1F; Fri, 4 Oct 2019 09:48:38 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46l4nf3tgyz4BY9; Fri, 4 Oct 2019 09:48:38 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [IPv6:2001:8b0:151:1:c4ea:bd49:619b:6cb3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: matthew/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4992C1E57D; Fri, 4 Oct 2019 09:48:38 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from leaf.local (unknown [88.212.184.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: m.seaman@infracaninophile.co.uk) by smtp.infracaninophile.co.uk (Postfix) with ESMTPSA id 21D7E2D25; Fri, 4 Oct 2019 09:48:36 +0000 (UTC) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: smtp.infracaninophile.co.uk/21D7E2D25; dkim=none; dkim-atps=neutral Subject: Re: svn commit: r513737 - head/textproc/py-python-slugify To: koobs@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201910032152.x93LqJei017087@repo.freebsd.org> <641d95f4-2ca2-14a5-029a-46b38c335f78@FreeBSD.org> From: Matthew Seaman Message-ID: <7537bbc7-9d61-4147-2b29-acd2ab4c126b@FreeBSD.org> Date: Fri, 4 Oct 2019 10:48:33 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <641d95f4-2ca2-14a5-029a-46b38c335f78@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2019 09:48:38 -0000 On 04/10/2019 03:33, Kubilay Kocak wrote: > On 4/10/2019 7:52 am, Matthew Seaman wrote: >> -RUN_DEPENDS= >> ${PYTHON_PKGNAMEPREFIX}unidecode>=0.04.16:converters/py-unidecode@${PY_FLAVOR} >> >> +RUN_DEPENDS= >> ${PYTHON_PKGNAMEPREFIX}text-unidecode>=1.3:converters/py-text-unidecode@${PY_FLAVOR} >> >> + >> +### Can alternatively require: >> +### >> ${PYTHON_PKGNAMEPREFIX}unidecode>=1.1.1:converters/py-unidecode@${PY_FLAVOR} >> >> +### but text-unidecode is preferred upstream. > > Good method for this is an OPTIONS_SINGLE with both options, with the > OPTIONS_DEFAULT being the 'preferred' version Yeah. I thought about doing that, and concluded that it was needless complexity. If you install this module using pip, it will always pull in text-unidecode as a dependency. The way the code is written it will opportunistically use unidecode only if that is installed and text-unidecode isn't -- but it's not like unidecode and text-unidecode conflict with each other, so pip or any reasonable packaging system are just going to install the preferred text-unidecode module. Basically, the support for using unidecode in the package seems pretty pointless. I added the comment just for my own reference, having wasted half an hour working all the above out, and then recalling I went through the same exercise several months ago and came to exactly the same conclusion. Cheers, Matthew