Date: Tue, 25 Apr 2017 15:12:44 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, John Baldwin <jhb@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r317409 - head/contrib/tcpdump Message-ID: <CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ@mail.gmail.com> In-Reply-To: <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org> References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com> <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:
...
> It is definitely more useful to note which repository and what VCS
> system the revision/hash/version refers to. But there's nothing
> inherently wrong about using a git hash. Github != git. It is merely an
> interface to git and is not required to use any of the git repositories
> on it given another mirror or local checkout. If a project uses git as
> their official VCS then a git hash is the proper reference.
The only issues with using git hashes stems from forced pushes and
the fact that only hashes can be garbage collected, but if we're using
an upstream that does that, they are using git wrong (it should only
be done for non-development mainlines). Then again, at least the
history will have been somewhat correct, as cvs/svn history can be
rewritten :/...
Thanks,
-Ngie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMATSJm2wGdzxRRNc7kSyyg3H8K_xeHo04XXSu5=rrv3pQ>