From owner-freebsd-arch@FreeBSD.ORG Mon Nov 7 05:36:29 2005 Return-Path: X-Original-To: freebsd-arch@FreeBSD.ORG Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9BCA16A41F for ; Mon, 7 Nov 2005 05:36:29 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 54AAE43D46 for ; Mon, 7 Nov 2005 05:36:29 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jA75YaX9003235; Sun, 6 Nov 2005 22:34:36 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 06 Nov 2005 22:35:03 -0700 (MST) Message-Id: <20051106.223503.97843133.imp@bsdimp.com> To: rink@stack.nl From: "M. Warner Losh" In-Reply-To: <20051106222359.GC46752@stack.nl> References: <20051106222359.GC46752@stack.nl> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sun, 06 Nov 2005 22:34:41 -0700 (MST) Cc: ed@fxq.nl, freebsd-arch@FreeBSD.ORG Subject: Re: FreeBSD/xbox: updated 7.0 patchset X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2005 05:36:29 -0000 In message: <20051106222359.GC46752@stack.nl> Rink Springer writes: : You can download the patches from : http://rink.nu/downloads/xbox-patches/xbox-7-current.diff. I hope this : patch will be committed to the FreeBSD source tree. Let me know any : suggestions for improvements. OK. I mostly like this patch. It is fairly clean and I'll be working on integrating it into the FreeBSD repo, with your help. I have just a few questions/comments on your patch. First, options XBOX shouldn't be in opt_global.h, but rather in opt_xbox.h that dev/fb/boot_font.c, i386/i386/machdep.c, i386/i386/pmap.c, i386/i386/vm_machdep, i386/isa/clock.c, and i386/pci/pci_cfgreg.c should be including. In general, we try to reserve opt_global.h for really global stuff. I don't understand the change to dev/fb/boot_font.c at all. Can you explain it in more detail? There's some style(9) issues with xboxfb.c. Specifically, there are a few cases in some switches that are inconsistantly formatted wrt other case statements. There are a few really gross hacks that are marked with XXX better fixes welcome. I'm a little torn about committing those, but at least they are all #ifdef XBOX. My question is how long do you think until there's a better solution for them? This is absolutely great work! Don't let my few quibbles and such get you down. I very much want to see xbox support committed to the tree. Warner