From owner-p4-projects@FreeBSD.ORG  Fri Jan  5 19:27:39 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B150F16A417; Fri,  5 Jan 2007 19:27:39 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 76CC516A40F;
	Fri,  5 Jan 2007 19:27:39 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 2580D13C458;
	Fri,  5 Jan 2007 19:27:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l05JRXr4041343;
	Fri, 5 Jan 2007 14:27:36 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Fri, 5 Jan 2007 12:32:27 -0500
User-Agent: KMail/1.9.1
References: <200701050802.l0582Gnq067583@repoman.freebsd.org>
In-Reply-To: <200701050802.l0582Gnq067583@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701051232.28019.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 05 Jan 2007 14:27:36 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2414/Thu Jan 4 20:41:51 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112535 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jan 2007 19:27:39 -0000

On Friday 05 January 2007 03:02, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=112535
> 
> Change 112535 by rdivacky@rdivacky_witten on 2007/01/05 08:01:24
> 
> 	No need to lock prison in a case of linux_use26 becuase the int
> 	setting is atomic and process cannot leave jail.
> 	
> 	Submitted by: kib
> 	Reviewed by: jhb
> 
> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_mib.c#6 
(text+ko) ====
> 
> @@ -237,12 +237,10 @@
>  
>  	pr = td->td_ucred->cr_prison;
>  	if (pr != NULL) {
> -		mtx_lock(&pr->pr_mtx);
>  		if (pr->pr_linux != NULL) {
>  			lpr = (struct linux_prison *)pr->pr_linux;
>  			use26 = lpr->pr_use_linux26;
>  		}
> -		mtx_unlock(&pr->pr_mtx);
>  	} else
>  		use26 = linux_use_linux26;
>  	
> 

Hmm, what is use26 set to if pr != NULL but pr->pr_linux == NULL?

-- 
John Baldwin