From owner-svn-ports-head@FreeBSD.ORG Sun Sep 8 16:10:58 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 2EA22C51; Sun, 8 Sep 2013 16:10:58 +0000 (UTC) Date: Sun, 8 Sep 2013 16:10:58 +0000 From: Alexey Dokuchaev To: Oliver Lehmann Subject: Re: svn commit: r326685 - in head: devel/mercator math/wfmath Message-ID: <20130908161058.GA71954@FreeBSD.org> References: <201309072043.r87KhjYi068970@svn.freebsd.org> <20130908033306.GA54749@FreeBSD.org> <20130908115253.Horde.idQUkFxUdsyF3rNQX9eeBA2@avocado.salatschuessel.net> <20130908145110.GB46281@FreeBSD.org> <20130908173930.Horde.pCVXzy4T-cXp8PC2LonKxg2@avocado.salatschuessel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130908173930.Horde.pCVXzy4T-cXp8PC2LonKxg2@avocado.salatschuessel.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 16:10:58 -0000 On Sun, Sep 08, 2013 at 05:39:30PM +0200, Oliver Lehmann wrote: > Alexey Dokuchaev wrote: > >Again, it's hard to understand that without the documenting why USE_GCC was > >used in the first place. Second, given the suggestion of simply removing > >misused CONFIGURE_ARGS (and provided that it does indeed solve the issue), > >I find it a bit hard to believe you could not have come up with it yourself > >Oliver. ;-) > > devel/mercator got USE_GCC as otherwise it wouldn't compile with a > gcc-compiled > math/wfmath. And math/wfmath got USE_GCC as I'm not able to fix those issues: > > http://beefy1.isc.freebsd.org/bulk/head-default/2013-09-04_23h56m58s/logs/wfmath-1.0.1.log > > math/wfmath has no CONFIGURE_ARGS to remove (devel/mercator has). Thanks, that would explain it. That was my original point: it would be nice if something like that, perhaps in a more concise form, to be recorded in the commit log, so dumbasses like me would not annoy you by their stupid followup mails. > >"yes" and "any" do different things, it's not the matter of style. "yes" > >means to use modern GCC compiler, even on systems that still use GCC as > >a system one by default (e.g. 8.x, 9.x). "any" means that literally any > >GCC version would suffice, which means that on our stable branches, I do > >not have to install some GCC 4.6+ since I already gave GCC 4.2 in the base. > > I looked the differenc between "any" and "yes"t already up after you told me > about "any" the first time by searching bsd.gcc.mk. I still think that it > would be better to have "any" also documented in bsd.gcc.mk at the top. > Maybe in the Examples section - how should anyone know about the two switches > and their meanings? Unfortunately, you're correct: these little things and nuances are poorly documented. I'll try to cook up a patch that talks about USE_GCC proper usage, unless you (or anyone else) beats me on that. ;-) Thanks, ./danfe