From owner-p4-projects  Tue Mar 25 12: 9:33 2003
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DC8F137B404; Tue, 25 Mar 2003 12:09:27 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 931)
	id 8DBFA37B401; Tue, 25 Mar 2003 12:09:27 -0800 (PST)
Date: Tue, 25 Mar 2003 14:09:27 -0600
From: Juli Mallett <jmallett@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 27377 for review
Message-ID: <20030325140927.A77141@FreeBSD.org>
References: <200303252007.h2PK7ZvH094216@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200303252007.h2PK7ZvH094216@repoman.freebsd.org>; from jmallett@FreeBSD.org on Tue, Mar 25, 2003 at 12:07:35PM -0800
Organisation: The FreeBSD Project <http://FreeBSD.org>
X-Alternate-Addresses: <jmallett@NewGold.NET>, <juli@jerkcity.com>, <flata@toxic.magnesium.net>, <jmallett@OpenDarwin.org>, <juli@arcti.ca>
X-Towel: Yes
X-Negacore: Yes
X-Title: Code Maven
X-Spam-Status: No, hits=-26.6 required=5.0
	tests=IN_REP_TO,QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES,
	      REPLY_WITH_QUOTES,USER_AGENT_MUTT
	autolearn=ham	version=2.50
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp)
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

* De: Juli Mallett <jmallett@FreeBSD.org> [ Data: 2003-03-25 ]
	[ Subjecte: PERFORCE change 27377 for review ]
> http://perforce.freebsd.org/chv.cgi?CH=27377
> 
> Change 27377 by jmallett@jmallett_dalek on 2003/03/25 12:07:03
> 
> 	Remove defunct pmap_phys_address.

Oops, hasty submit.  Other changes noted below

> Affected files ...
> 
> .. //depot/projects/mips/sys/mips/mips/support.S#6 edit
> .. //depot/projects/mips/sys/mips/mips/vm_machdep.c#5 edit
> .. //depot/projects/mips/sys/mips/sgimips/machdep_sgimips.c#5 edit
> 
> ==== //depot/projects/mips/sys/mips/mips/support.S#6 (text+ko) ====
> 
> @@ -153,6 +153,16 @@
>  END(suword32)
>  
>  /*
> + * suword64(9)
> + * <v0>int suword64(<a0>void *addr, <a1>long word)
> + */
> +ENTRY(suword64)
> +	li	v0, -1
> +	jr	ra
> +	nop
> +END(suword64)
> +
> +/*
>   * Stubs for fetch(9) XXX
>       fubyte()    Fetches a byte of data from the user-space address base.
>  

Add suword64 for ELF64 stuff.

> ==== //depot/projects/mips/sys/mips/mips/vm_machdep.c#5 (text+ko) ====
> 
> @@ -27,14 +27,17 @@
>   */
>  
>  #include <sys/param.h>
> +#include <sys/systm.h>
>  #include <sys/kernel.h>
>  #include <sys/lock.h>
>  #include <sys/mutex.h>
>  #include <sys/time.h>
> +#include <sys/proc.h>
>  #include <sys/queue.h>

Missing headers for prototypes of functions used/declared herein.

>  #include <machine/cpufunc.h>
>  #include <machine/frame.h>
> +#include <machine/md_var.h>
>  
>  #include <vm/vm.h>
>  #include <vm/vm_param.h>
> @@ -69,6 +72,7 @@
>  void
>  cpu_throw(void)
>  {
> +	panic("cpu_throw: called.\n");

Make cpu_throw not return.

>  }
>  
>  void
> @@ -102,7 +106,7 @@
>  }
>  
>  void
> -cpu_set_upcall_kse(struct thread *td, struct kse *ke)
> +cpu_set_upcall_kse(struct thread *td, struct kse_upcall *ku)

Catch up with KSE API changes.

>  {
>  }
>  
> 
> ==== //depot/projects/mips/sys/mips/sgimips/machdep_sgimips.c#5 (text+ko) ====
> 
> @@ -27,6 +27,7 @@
>   */
>  
>  #include <sys/types.h>
> +#include <sys/systm.h>

Add missing header for prototype of printf.

>  
>  #include <machine/cpufunc.h>
>  #include <machine/cpuregs.h>

-- 
juli mallett. email: jmallett@freebsd.org; aim: bsdflata; efnet: juli;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message