Date: Fri, 23 Mar 2018 07:26:19 -0600 From: Warner Losh <imp@bsdimp.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Andriy Gapon <avg@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: geom->access problem and workaround Message-ID: <CANCZdfqfHgdO7FkRU0ymbQgvbBksBQ-tG4CYEcYSPpD5Ree0Lg@mail.gmail.com> In-Reply-To: <888.1521797403@critter.freebsd.dk> References: <809d9254-ee56-59d8-69a4-08838e985cea@FreeBSD.org> <CANCZdfpPGXbKnMfuXWJFVk3xpk-hj8%2BtnsscbySeQTOrB2M-9w@mail.gmail.com> <56619.1520878022@critter.freebsd.dk> <5e416eb6-0e79-1419-f09a-eb747215dc28@FreeBSD.org> <888.1521797403@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 23, 2018 at 3:30 AM, Poul-Henning Kamp <phk@phk.freebsd.dk>
wrote:
> --------
> In message <5e416eb6-0e79-1419-f09a-eb747215dc28@FreeBSD.org>, Andriy
> Gapon writes:
> >On 12/03/2018 20:07, Poul-Henning Kamp wrote:
> >> If we want to have an architectural sound way to do slow operations
> >> before any "user-I/O" is initiated, the right way to do so is to
> >> define new BIO_OPEN and BIO_CLOSE operation, and insist via asserts
> >> than all BIO_{READ|WRITE|DELETE} are wrapped in these.
>
> >What do you think?
>
> I don't see that changing anything...
>
> GEOM rests on a set of assumptions, if you violate them, you get panics.
I agree. The cd panic is a problem in the cd driver where it bogusly uses
runccb in a context that can't sleep.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqfHgdO7FkRU0ymbQgvbBksBQ-tG4CYEcYSPpD5Ree0Lg>