Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 24 Jan 2015 21:23:53 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r277661 - stable/10/sys/fs/ext2fs
Message-ID:  <201501242123.t0OLNreL004454@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: pfg
Date: Sat Jan 24 21:23:53 2015
New Revision: 277661
URL: https://svnweb.freebsd.org/changeset/base/277661

Log:
  MFC	r277301:
  ext2: cosmetical issues
  
  Minor sorting and note when the cases are expected to fall through.

Modified:
  stable/10/sys/fs/ext2fs/ext2_hash.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/fs/ext2fs/ext2_hash.c
==============================================================================
--- stable/10/sys/fs/ext2fs/ext2_hash.c	Sat Jan 24 21:21:39 2015	(r277660)
+++ stable/10/sys/fs/ext2fs/ext2_hash.c	Sat Jan 24 21:23:53 2015	(r277661)
@@ -196,10 +196,10 @@ ext2_prep_hashbuf(const char *src, int s
 {
 	uint32_t padding = slen | (slen << 8) | (slen << 16) | (slen << 24);
 	uint32_t buf_val;
-	int len, i;
-	int buf_byte;
 	const unsigned char *ubuf = (const unsigned char *)src;
 	const signed char *sbuf = (const signed char *)src;
+	int len, i;
+	int buf_byte;
 
 	if (slen > dlen)
 		len = dlen;
@@ -265,6 +265,7 @@ ext2_htree_hash(const char *name, int le
 	switch (hash_version) {
 	case EXT2_HTREE_TEA_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_TEA:
 		while (len > 0) {
 			ext2_prep_hashbuf(name, len, data, 16, unsigned_char);
@@ -277,11 +278,13 @@ ext2_htree_hash(const char *name, int le
 		break;
 	case EXT2_HTREE_LEGACY_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_LEGACY:
 		major = ext2_legacy_hash(name, len, unsigned_char);
 		break;
 	case EXT2_HTREE_HALF_MD4_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_HALF_MD4:
 		while (len > 0) {
 			ext2_prep_hashbuf(name, len, data, 32, unsigned_char);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501242123.t0OLNreL004454>