Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Nov 2019 15:00:53 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r516900 - in head/multimedia: ffms2 vapoursynth vapoursynth-l-smash-works
Message-ID:  <20191107140053.d36yftvnvxceyhps@ogg.in.absolight.net>
In-Reply-To: <zhh7-gbfu-wny@FreeBSD.org>
References:  <201911061642.xA6GgS3V041740@repo.freebsd.org> <20191107081032.kqotphm5wzk3bhgf@atuin.in.mat.cc> <zhh7-gbfu-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--437gb63fsdybtboy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 07, 2019 at 12:42:13PM +0100, Jan Beich wrote:
> Mathieu Arnold <mat@FreeBSD.org> writes:
>=20
> > On Wed, Nov 06, 2019 at 04:42:28PM +0000, Jan Beich wrote:
> >
> >> Author: jbeich
> >> Date: Wed Nov  6 16:42:28 2019
> >> New Revision: 516900
> >> URL: https://svnweb.freebsd.org/changeset/ports/516900
> >>=20
> >> Log:
> >>   multimedia/vapoursynth: mark BROKEN on non-x86
> >>=20
> >> Modified:
> >>   head/multimedia/ffms2/Makefile   (contents, props changed)
> >>   head/multimedia/vapoursynth-l-smash-works/Makefile   (contents, prop=
s changed)
> >>   head/multimedia/vapoursynth/Makefile   (contents, props changed)
> >>=20
> >> Modified: head/multimedia/ffms2/Makefile
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >> --- head/multimedia/ffms2/Makefile	Wed Nov  6 16:42:19 2019	(r516899)
> >> +++ head/multimedia/ffms2/Makefile	Wed Nov  6 16:42:28 2019	(r516900)
> >> @@ -11,18 +11,24 @@ COMMENT=3D	FFmpeg-based source library and VapourS=
ynth p
> >>  LICENSE=3D	MIT
> >>  LICENSE_FILE=3D	${WRKSRC}/COPYING
> >> =20
> >> +.if ${MACHINE_ARCH} =3D=3D amd64 || ${MACHINE_ARCH} =3D=3D i386
> >
> > We never use MACHINE_ARCH in the ports tree, we use ARCH, and it is only
> > available after an include.  All our tools use/set ARCH, so, please use
> > it.
>=20
> This is a temporary workaround, so avoiding "svn blame" churn is preferre=
d.
> Also, I planned to switch ARCH to use MACHINE_ARCH internally in bug 2154=
01.

Whatever the reason, MACHINE_ARCH must never be used for tests, please
fix it to use ARCH.=20

Regards,

--=20
Mathieu Arnold

--437gb63fsdybtboy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl3EI5RfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkgKdw//Tv3PCiaueM2lkmg7J9Ib/5wt9MScDVEn+wYrB5UryzJbiUD1eN1nRTS6
Vn3PYUYX+3jAWiNn/oPd9BXTdGESOHtaQE3nBH4IVvlYU6RTQXe+kEomt7hoMW/g
EQNBWLHqL/ZRXR9s8yJXhgQn8VF8GYsZ+os9UNqv2w78Yw5PITGnMAfzmqT3+u6b
uBiZbrvKzmIVTCX2OHWZh6b1XuSTcImlg0svIkWieIhnEcx667o2WSjx4JACfRvA
N/oHk+aNLYMrDQVvvyKnZxmdjb+h/hDTWLHgrTsexV6Vsc/H7cweXaOV3rfdNVQL
hoJJxV5hZALFrq0IWA6KYUvfsOknBVMqcHAQgPU6fDbtiJbr+LuSyv68NrpmOvIN
FncSzMTn6ekCRegPlcJXmSYXPyPc8A6/kCQJmUDzfoiEJFZ8bS9uWBMnphLNNg+u
Zbrdnb0UyPy54rQPSCtf54Ikg7rnrlo1LuQxb5HqKqYCvPhNV47lIRfOF5gmYJ3t
x5PGXtcUi0M+Zot1uU1HKz7wIR5xX62ZSC4FQWnFYFEcAZtEaxtELNH5RT0DWSCp
ParqAOuZmZFVgh0132qgN0n59V0CtZdy9cn2lCarUUnQACeGmk10HXBt2sbVzqj8
TbrzUJvufZl4ZnbdvivVeGRv61xbAHWn+WhQLyKAIsgUKeYTjrw=
=rJB2
-----END PGP SIGNATURE-----

--437gb63fsdybtboy--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191107140053.d36yftvnvxceyhps>