Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Dec 2018 20:14:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 234508] sysutils/grub2: Update to recent snapshot, fix build with GCC 8
Message-ID:  <bug-234508-7788-nSBAn8X6GU@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-234508-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-234508-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234508

--- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> ---
(In reply to bergerkos from comment #2
> in this snapshot grub-mkconfig does not make problems prefixing "t"
> as reported in r488585.

It's good that they have fixed most of the non-portable sed -e 's/^/\t/'.
I still see some in at least util/grub.d/30_os-prober.in, so I do not
think that this is fixed completely.  Probably could be easily fixed
with a single patch instead of falling back to gsed now though.

> And as for r484145, I ran portlint and did what it suggested, so
> no it finds no mistakes in my Makefile.

r484145 also removed CONFLICTS, for example.

> Because "USES=3Dautoreconf" doesn't do all that the autogen.sh does.
> That scripts does some other things as well.

Ok, it seems to do a lot.  Is there a need to run autoreconf twice?
Both autogen.sh and the framework do it.  Would USES=3Dautoreconf:build
suffice?

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234508-7788-nSBAn8X6GU>