Date: Fri, 24 Jan 2014 00:41:03 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r261093 - stable/10/sys/dev/mfi Message-ID: <201401240041.s0O0f3o5049058@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Fri Jan 24 00:41:02 2014 New Revision: 261093 URL: http://svnweb.freebsd.org/changeset/base/261093 Log: MFC r260521: Remove not applicable PI_SDTR_ABLE and PI_WIDE_16 hba_inquiry flags to make CAM to not try negotiate unsupported settings and suppress warnings. While there, enable command queuing on pass-through devices, announced in hba_inquiry, but disabled. Even though queue size is very small, It seems working well enough. Modified: stable/10/sys/dev/mfi/mfi_cam.c Directory Properties: stable/10/ (props changed) Modified: stable/10/sys/dev/mfi/mfi_cam.c ============================================================================== --- stable/10/sys/dev/mfi/mfi_cam.c Fri Jan 24 00:14:14 2014 (r261092) +++ stable/10/sys/dev/mfi/mfi_cam.c Fri Jan 24 00:41:02 2014 (r261093) @@ -216,7 +216,7 @@ mfip_cam_action(struct cam_sim *sim, uni struct ccb_pathinq *cpi = &ccb->cpi; cpi->version_num = 1; - cpi->hba_inquiry = PI_SDTR_ABLE|PI_TAG_ABLE|PI_WIDE_16; + cpi->hba_inquiry = PI_TAG_ABLE; cpi->target_sprt = 0; cpi->hba_misc = PIM_NOBUSRESET|PIM_SEQSCAN; cpi->hba_eng_cnt = 0; @@ -244,6 +244,8 @@ mfip_cam_action(struct cam_sim *sim, uni break; case XPT_GET_TRAN_SETTINGS: { + struct ccb_trans_settings_scsi *scsi = + &ccb->cts.proto_specific.scsi; struct ccb_trans_settings_sas *sas = &ccb->cts.xport_specific.sas; @@ -252,6 +254,9 @@ mfip_cam_action(struct cam_sim *sim, uni ccb->cts.transport = XPORT_SAS; ccb->cts.transport_version = 0; + scsi->valid = CTS_SCSI_VALID_TQ; + scsi->flags = CTS_SCSI_FLAGS_TAG_ENB; + sas->valid &= ~CTS_SAS_VALID_SPEED; sas->bitrate = 150000;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401240041.s0O0f3o5049058>