From owner-freebsd-current Wed Aug 26 02:28:00 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA00892 for freebsd-current-outgoing; Wed, 26 Aug 1998 02:28:00 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA00886 for ; Wed, 26 Aug 1998 02:27:57 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.9.1/8.8.5) with SMTP id KAA05076; Wed, 26 Aug 1998 10:27:04 +0100 (BST) Date: Wed, 26 Aug 1998 10:27:04 +0100 (BST) From: Doug Rabson To: Stephen McKay cc: freebsd-current@FreeBSD.ORG, "John S. Dyson" Subject: Re: Serious bug in vm_page.h in current In-Reply-To: <199808260909.TAA11802@nymph.dtir.qld.gov.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 26 Aug 1998, Stephen McKay wrote: > On Wednesday, 26th August 1998, Doug Rabson wrote: > > >How about this: > > > >Index: vm_page.h > >=================================================================== > > >+static __inline void > >+vm_page_busy(vm_page_t m) > >+{ > >+ vm_page_busy(m); > > } > > An "oops"? Otherwise looking good. Dodgy global replace :-) > > But to be picky, I prefer vm_page_flag_clear() and vm_page_flag_set() to > vm_page_clear_flag() and vm_page_set_flag(). Similarly, I think that > vm_page_io_start() and vm_page_io_finish() would be better than > vm_page_start_io() and vm_page_finish_io(). I hope you can see my > reasoning. > > But, I'm not going to arm wrestle you for it if you don't like it. I normally use class,verb,noun construction in writing apis for no good reason. The api in vm_object uses class,noun,verb mostly (apart from my flag changes...) It would probably make the thing more self-consistent to change the names. What do you think John? -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message