Date: Mon, 11 Feb 2013 10:50:01 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Alfred Perlstein <bright@mu.org> Cc: Kirk McKusick <mckusick@mckusick.com>, freebsd-arch@FreeBSD.org Subject: Re: Proposal: Unify printing the function name in panic messages() Message-ID: <5118BEC9.1090708@gmx.de> In-Reply-To: <5116504A.7010409@mu.org> References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org> <51160E06.1070404@gmx.de> <20130209195417.C1753@besplex.bde.org> <51161C10.9070002@gmx.de> <5116504A.7010409@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
(Alfred accidently only replied to me.) On 09.02.2013 14:34, Alfred Perlstein wrote: > On 2/9/13 1:51 AM, Christoph Mallon wrote: >> As bde points out, optimisations interfere with location information gathered at runtime. >> Having the right name of the function in the panic, ensures that at least the starting point is right. >> My PANIC() macro guarantees exactly this. > > I like this fix, my only nit is asthetics. > > Would we just turn panic() into a macro instead of making PANIC() everywhere in the kernel? > > Too many uppercase macros are hard on the eyes. This is a good point. I will adjust the patches accordingly. Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5118BEC9.1090708>