Date: Mon, 23 Oct 2000 10:28:17 -0400 (EDT) From: Mikhail Teterin <mi@monsta.privatelabs.com> To: FreeBSD-gnats-submit@freebsd.org Cc: cwt@freebsd.org Subject: ports/22258: adding a WITHOUT_PLOT option to the misc/amanda24 port Message-ID: <200010231428.e9NESHk42998@monsta.privatelabs.com>
next in thread | raw e-mail | index | archive | help
>Number: 22258
>Category: ports
>Synopsis: adding a WITHOUT_PLOT option to the misc/amanda24 port
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 23 14:20:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Mikhail Teterin
>Release: FreeBSD 4.1.1-STABLE i386
>Organization:
Virtual Estates, Inc.
>Environment:
>Description:
I believe it to be a bug, that the mostly server package
-- Amanda requires GNUplot (which requires X11) to build
and run. Since the software itself does not require GNUplot,
the port, IMHO, should not require it either.
This simple patch adds an option WITHOUT_PLOT to the port
-- the old behaviour is preserved by default. Should the
opinion, that WITH_PLOT has to be the option, prevail, it
will be easy to change the port one step further.
>How-To-Repeat:
>Fix:
cvs diff: Diffing .
Index: Makefile
===================================================================
RCS file: /net/raidbox/raid/ncvs/ports/misc/amanda24/Makefile,v
retrieving revision 1.30
diff -U1 -r1.30 Makefile
--- Makefile 2000/06/16 21:51:40 1.30
+++ Makefile 2000/10/23 14:20:08
@@ -15,4 +15,14 @@
+.ifndef WITHOUT_PLOT
BUILD_DEPENDS= gnuplot:${PORTSDIR}/math/gnuplot
RUN_DEPENDS= gnuplot:${PORTSDIR}/math/gnuplot
+PLIST_SUB= PLOT=''
+pre-fetch:
+ # To build without the amplot utility, which requires gnuplot,
+ # which requires X11, define the WITHOUT_PLOT flag, for example:
+ # make -DWITHOUT_PLOT
+ #
+.else
+PLIST_SUB= PLOT='@comment '
+.endif
Index: pkg-plist
===================================================================
RCS file: /net/raidbox/raid/ncvs/ports/misc/amanda24/pkg-plist,v
retrieving revision 1.15
diff -U1 -r1.15 pkg-plist
--- pkg-plist 2000/06/15 17:12:39 1.15
+++ pkg-plist 2000/10/23 14:16:10
@@ -13,8 +13,8 @@
libexec/amanda/amandad
-libexec/amanda/amcat.awk
+%%PLOT%%libexec/amanda/amcat.awk
libexec/amanda/amidxtaped
libexec/amanda/amindexd
-libexec/amanda/amplot.awk
-libexec/amanda/amplot.g
-libexec/amanda/amplot.gp
+%%PLOT%%libexec/amanda/amplot.awk
+%%PLOT%%libexec/amanda/amplot.g
+%%PLOT%%libexec/amanda/amplot.gp
libexec/amanda/amtrmidx
@@ -49,3 +49,3 @@
sbin/amoverview
-sbin/amplot
+%%PLOT%%sbin/amplot
sbin/amrecover
cvs diff: Diffing files
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010231428.e9NESHk42998>