From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 1 08:30:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0087E16A420 for ; Mon, 1 Oct 2007 08:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ABABB13C4A5 for ; Mon, 1 Oct 2007 08:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l918U103055356 for ; Mon, 1 Oct 2007 08:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l918U1Sq055355; Mon, 1 Oct 2007 08:30:01 GMT (envelope-from gnats) Resent-Date: Mon, 1 Oct 2007 08:30:01 GMT Resent-Message-Id: <200710010830.l918U1Sq055355@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jaap Boender Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE9EE16A468 for ; Mon, 1 Oct 2007 08:26:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A07FA13C46A for ; Mon, 1 Oct 2007 08:26:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l918Q1C0044187 for ; Mon, 1 Oct 2007 08:26:01 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id l918Q1i9044185; Mon, 1 Oct 2007 08:26:01 GMT (envelope-from nobody) Message-Id: <200710010826.l918Q1i9044185@www.freebsd.org> Date: Mon, 1 Oct 2007 08:26:01 GMT From: Jaap Boender To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/116780: libtunepimp fails to compile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2007 08:30:02 -0000 >Number: 116780 >Category: ports >Synopsis: libtunepimp fails to compile >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 01 08:30:01 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Jaap Boender >Release: 6.2-STABLE >Organization: >Environment: FreeBSD marion-dufresne.pps.jussieu.fr 6.2-STABLE FreeBSD 6.2-STABLE #6: Mon Aug 20 16:21:12 CEST 2007 root@marion-dufresne.pps.jussieu.fr:/usr/obj/usr/src/sys/MARION-DUFRESNE i386 >Description: The MP4Close function in my version of libmp4 (port mpeg4ip-libmp4v2-1.6) doesn't return a bool, but a void, which results in libtunepimp failing to compile. >How-To-Repeat: install audio/libtunepimp. >Fix: Adding the attached patch to the files directory of the port should solve the problem. Patch attached with submission follows: --- plugins/mp4/mp4.cpp.orig 2007-10-01 10:17:48.000000000 +0200 +++ plugins/mp4/mp4.cpp 2007-10-01 10:18:19.000000000 +0200 @@ -231,9 +231,7 @@ strcpy(mdata->fileFormat, fileName + strlen(fileName) - 3); - if (!MP4Close(mp4file)) - return 0; - + MP4Close(mp4file); return 1; } @@ -315,8 +313,7 @@ sprintf(temp, "%d", mdata->nonAlbum); MP4SetMetadataFreeForm(mp4file, "MusicBrainz Non-Album", (u_int8_t *)temp, strlen(temp) + 1); - if (!MP4Close(mp4file)) - return 0; + MP4Close(mp4file); #ifndef WIN32 if (!MP4Optimize(utf8ToEncoding(fileName, encoding).c_str())) >Release-Note: >Audit-Trail: >Unformatted: