Date: Tue, 01 Apr 2014 13:11:49 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Joe Nosay <superbisquit@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: UDP Lite support Message-ID: <533A4A95.7010905@FreeBSD.org> In-Reply-To: <CA%2BWntOvokbYxQKCbnWbvnnuvYh25DE2kKLoVAXE2gQyvD1Afyg@mail.gmail.com> References: <CA%2BWntOugdnjM1SvFcEtWb8=heQCOBs2-c97EUKsfEHSmi1HRSw@mail.gmail.com> <201403261122.43541.jhb@freebsd.org> <5333F020.8000200@FreeBSD.org> <201403271221.29864.jhb@freebsd.org> <533A2285.2030705@FreeBSD.org> <CA%2BWntOvokbYxQKCbnWbvnnuvYh25DE2kKLoVAXE2gQyvD1Afyg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Nosay wrote: > On Mon, Mar 31, 2014 at 10:20 PM, Kevin Lo <kevlo@freebsd.org> wrote: > >> On 2014/03/28 00:21, John Baldwin wrote: >> >>> On Thursday, March 27, 2014 5:32:16 am Kevin Lo wrote: >>> >>>> Are you interested in working on these and report back? >>>>>> The revised patch is available at: >>>>>> http://people.freebsd.org/~kevlo/udplite.diff >>>>>> >>>>> Thank you for your suggestions. >>>> A few suggestions: >>>>> - I would just drop the INP lock and return EOPNOTSUPP directly rather >>>>> than using goto's to 'bad_setoptname' and 'bad_getoptname' so the >>>>> UDP-lite options are self-contained. >>>>> >>>> Fixed. >>>> >>> Thanks. >>> >>> - I'm not a super big fan of all the udp_common_* macros only because >>>>> I think it obfuscates things. At the very least, please move these >>>>> things out of the header and into udp_usrreq.c so they are closer >>>>> to the implementation. I would even suggest making them inline >>>>> functions instead of macros. >>>>> >>>> Okay, I removed two udp_common_* macros. I also renamed >>>> udp_common_init() >>>> to udp_udplite_init() and moved it into udp_usrreq.c. Using a macro here >>>> to follow the style used in SCTP (sctp_os_bsd.h). >>>> >>>> Here's a third version of the udp-lite patch: >>>> http://people.freebsd.org/~kevlo/udplite.diff >>>> >>> Ok, I would say that udp_common_init() is actually a better name if you >>> keep >>> the macro (which I think is fine) rather than udp_udplite_init() as the >>> macro >>> is not specific to UDP Lite. However, thanks for moving the macros out >>> of the >>> header. >>> >> Thank you John. glebius@ suggests we don't need to have two absolutely >> equal uma zones since most systems don't run UDP-Lite. >> If practice shows that a differentiation at zone level between UDP and >> UDP-Lite PCBs is important, then it could be done later. >> >> Following up with a fourth version of the udp-lite patch. >> http://people.freebsd.org/~kevlo/udplite.diff >> >> On top of the previous versions, this: >> - removes a uma zone for udp-lite >> - udp_common_ctlinput() belongs under #ifdef INET >> - removes sysctl nodes for udp-lite. >> - bumps version and adds my copyright. >> >> Kevin >> >> >> > Do I patch over the current src- which was already patched with version 3- > or do I just start new? Start new, thanks. Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?533A4A95.7010905>