Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jan 2014 11:03:11 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Antoine Brodin <antoine@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r338284 - head/comms/gnocky
Message-ID:  <20140109110311.GA46469@FreeBSD.org>
In-Reply-To: <201312311227.rBVCRwfe081248@svn.freebsd.org>
References:  <201312311227.rBVCRwfe081248@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 31, 2013 at 12:27:58PM +0000, Antoine Brodin wrote:
> New Revision: 338284
> URL: http://svnweb.freebsd.org/changeset/ports/338284
> 
> -.if ${PORT_OPTIONS:MNLS}
> -USES+=		gettext
> -PLIST_SUB+=	NLS=""
> -.else
> -CONFIGURE_ARGS+=	--disable-nls
> -PLIST_SUB+=	NLS="@comment "
> -.endif
> +OPTIONS_SUB=	yes
> +NLS_USES=	gettext
> +NLS_CONFIGURE_ENABLE=	nls

Why not just NLS_CONFIGURE_OFF= --disable-nls?  It looks like NLS support is
on by default, and NLS_CONFIGURE_OFF saves passing explicit --enable-nls to
the args (thus making them shorter).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140109110311.GA46469>