Date: Thu, 26 Aug 1999 08:28:29 +0000 (GMT) From: Alfred Perlstein <bright@wintelcom.net> To: hackers@freebsd.org Cc: fs@freebsd.org, Michael Hancock <michaelh@cet.co.jp>, David Greenman <dg@root.com> Subject: HEADS UP Reviewers. VFS changes to be committed. Message-ID: <Pine.BSF.4.05.9908260220590.6392-100000@fw.wintelcom.net>
next in thread | raw e-mail | index | archive | help
I've posted 2 times asking for someone to review these diffs: http://big.endian.org/~bright/freebsd/in_progress/vfs-fhsyscall.diff Am I to take it that silence is accpetance? I'll be committing this to -current tonight or tomorrow unless I get feedback. See attached email for details. thank you, -Alfred Perlstein - [bright@rush.net|alfred@freebsd.org] Wintelcom systems administrator and programmer - http://www.wintelcom.net/ [bright@wintelcom.net] ---------- Forwarded message ---------- Date: Tue, 24 Aug 1999 17:24:42 +0000 (GMT) From: Alfred Perlstein <bright@wintelcom.net> To: fs@freebsd.org Subject: VFS cleanup and fh*() syscalls almost complete. I have tested this code lightly, it compiles cleanly and the NFS server code still seems to work. http://big.endian.org/~bright/freebsd/in_progress/vfs-fhsyscall.diff Several things have been done, mostly inspired by NetBSD: 1) VFS_FHTOVP has been split into 2 VFS ops: VFS_FHTOVP now only takes a mountpoint, filehandle and **vnode VFS_CHECKEXP now takes the export checking arguments that VFS_FHTOVP used to take. 2) The casting of VFS ops to eopnotsupp() has been removed and vfs_nop*() functions have been put into kern/vfs_default.c This makes it more clear that certain VFS-ops are giving default behavior, either returning automatic success or returning EOPNOTSUPP. Someone mentioned that EOPNOTSUPP should be replaced by EINVAL, can that person please speak up? Also, some filesystems that actually implemented VFS-ops that did nothing or returned EOPNOTSUPP have had those functions deleted except when they are essential to understanding the VFS, or if it looked like they may eventually be filled in. 3) fh(open|stat|statfs) have been haphazardly implemented, meaning I won't be able to test them until tonight. Testers? Critics? Comments? please? If you're wondering why/what I'm doing, it's the kernel support for a lockd that I'm working on, as well as a cleanup I thought would make it easier to understand our filesystem code. I'm sure some people will be wondering: Why does VFS_CHECKEXP take a vnode and not a mount point? Hopefully in the future a filesystem will be able to more restrictively export its files, this will help facilitate that. Lastly, I'm jumping the gun here and posting a lightly tested patch because I've had to re-merge this stuff 3 times already and would like comments on not only functionality, but style as well. This way I can either commit it, (after more testing) or scrap the whole project. What I have to do next is make the fh*() syscalls solid and investigate the veto locking ideas that have been brought up in the past. thanks for you time, -Alfred Perlstein - [bright@rush.net|alfred@freebsd.org] Wintelcom systems administrator and programmer - http://www.wintelcom.net/ [bright@wintelcom.net] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9908260220590.6392-100000>