Date: Mon, 8 Jul 2013 08:52:40 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: kde@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: port options are not saved in some ports Message-ID: <20130708065240.GC4078@ithaqua.etoilebsd.net> In-Reply-To: <51DA56C6.3030401@FreeBSD.org> References: <51DA56C6.3030401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 08, 2013 at 09:05:58AM +0300, Andriy Gapon wrote: >=20 > It seems that port options do not "stick" in the following ports: > ukrainian/kde4-l10n > russian/kde4-l10n >=20 > Could you please take a look? >=20 > --=20 > Andriy Gapon That is because misc/kde4-l10n/files/bsd.l10n.mk is totally wrong it does =2E.. =2Einclude <bsd.port.pre.mk> =2E.. =2Einclude <bsd.port.options.mk> =2E.. =2Einclude <bsd.port.post.mk> First the right order in that case should be: =2E.. =2Einclude <bsd.port.options.mk> =2E.. =2Einclude <bsd.port.pre.mk> =2E.. =2Einclude <bsd.port.post.mk> Second in that case (kde) The pre.mk/post.mk can be removed just keeping the options.mk and given that we now have the helpers options.mk can also be removed. The check for variables in OPTIONS_DEFINE is also useless (already done by = the framework) defining OPTIONS_DEFINE and OPTIONS_DEFAULT to some empty values is also useless. http://people.freebsd.org/~bapt/kde.diff now just replace bsd.port.post.mk in russian/kde4-l10n/Makefile by bsd.port= =2Emk and everything will work properly again. regards, Bapt --vOmOzSkFvhd7u8Ms Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlHaYbgACgkQ8kTtMUmk6Exr0ACfSXy+s0M6/+/vuuffvAR1p9Na 93sAn1QlWKZbNHBJ+VMRCdiHOG6d/8Um =qVIJ -----END PGP SIGNATURE----- --vOmOzSkFvhd7u8Ms--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130708065240.GC4078>