From owner-cvs-all Mon Feb 18 7:33:32 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 4FFEB37B503; Mon, 18 Feb 2002 07:33:21 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id g1IFUKN40700; Mon, 18 Feb 2002 16:30:20 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Andrew Gallatin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/sys vnode.h src/sys/ufs/ufs ufs_vnops.c In-Reply-To: Your message of "Mon, 18 Feb 2002 10:28:20 EST." <20020218102820.A31981@grasshopper.cs.duke.edu> Date: Mon, 18 Feb 2002 16:30:20 +0100 Message-ID: <40698.1014046220@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020218102820.A31981@grasshopper.cs.duke.edu>, Andrew Gallatin wri tes: >Poul-Henning Kamp [phk@FreeBSD.org] wrote: >> phk 2002/02/17 13:15:36 PST >> >> Modified files: >> sys/kern vfs_subr.c >> sys/sys vnode.h >> sys/ufs/ufs ufs_vnops.c >> Log: >> Move the stuff related to select and poll out of struct vnode. >> The use of the zone allocator may or may not be overkill. >> There is an XXX: over in ufs/ufs/ufs_vnops.c that jlemon may need >> to revisit. > >The same one that's now causing me to see: > > ufs_kqfilter: vnode with no v_pollinfo > >on console when I run tail -f on a file, huh? Damn, this was the testcase I didn't manage to think of. I'll fix this as soon as I have picked up my kids... If you want to take a stab at it, remove the "static __inline" from v_addpollinfo() in vfs_subr.c and add a call to it in ufs/ufs/ufs_vnops.c where that printf is. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message