From owner-freebsd-scsi@freebsd.org Tue Apr 4 21:04:08 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B716FD2F9CB for ; Tue, 4 Apr 2017 21:04:08 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E38E9D4 for ; Tue, 4 Apr 2017 21:04:08 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: by mail-io0-x22f.google.com with SMTP id l7so103762196ioe.3 for ; Tue, 04 Apr 2017 14:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vSYPYhdkUrUl4iUenYSfppUReAy+lQrfmUC8MwlvgmI=; b=ua2Tl/lvdK8QJTINy/Kx9yeVs4pTvuo7eLGbk76n9botZaV8osc98UxVPGtJmy1jWR kuXqjgGgM4f6yw5lD2vzlaszk+kRG8KSIN0HRxpYu/8TOvHkjJMJddhQRgL8/bX34n1s 0GJOSCpPXvOzAF404LFie64agOKPPj6El8ebRhqOucV2S7bEuD5QUrclS0qwk3MrAwwk +y3uNEvKfBx9NBsy/EjjMsHFsosJ1WuFd90UvbT8I273gsVhgTJoa8ZcSXpAgkS70QsJ 4ZVHvEcP1xu0w/ZGLVjfGP9iJXFzv4QWOMd9ejBBl9ttfU1IpGrKhFkewSvQe4rNljhr vbSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vSYPYhdkUrUl4iUenYSfppUReAy+lQrfmUC8MwlvgmI=; b=qYqQ5ouVnAJJry+beiH5lQIimv7OH2DOS8zlKvhGI6JNIRVHiQ4SWyvor2cpmVpB3s GozW5T11K2VmUgEbPnWr1oNgS7OLmMJT/jtQZWc1EC/XnAT57FoC95BQawzstiduF7DM cSaIu2Xis+H/mzB1AAL8WU9cKyWdm/QknlAHViJaeNLFi2e9nwc8Vk8brGS/t87KMvAx fTTwA+BOpLChH//VMDm4KPnA12FavrJ1+ECqb7wz542/GslvcGpUrRTMIPOH52AHsy0v 2EDtqV05I/yE9VCdGWRYWLGessctN1rNBe0wMTYmTQLI9szSckCnHHsN1aNKWIPEl61K u3ZQ== X-Gm-Message-State: AFeK/H3e88WUYkBJBI22hIZuVizJ+79k5kMMWbGMcHs1XXxl0DURlbDtiaD2nhnn5KvScGkMIm4+7azHRVVVPw== X-Received: by 10.107.149.7 with SMTP id x7mr23730682iod.167.1491339847873; Tue, 04 Apr 2017 14:04:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.145.206 with HTTP; Tue, 4 Apr 2017 14:04:07 -0700 (PDT) In-Reply-To: References: From: Jim Harris Date: Tue, 4 Apr 2017 14:04:07 -0700 Message-ID: Subject: Re: [RFC] CAM pass(4) patch for NVMe To: Warner Losh Cc: Chuck Tuffli , freebsd-scsi Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 21:04:08 -0000 On Tue, Apr 4, 2017 at 1:50 PM, Warner Losh wrote: > On Tue, Apr 4, 2017 at 2:48 PM, Chuck Tuffli wrote: >> On Tue, Apr 4, 2017 at 11:13 AM, Warner Losh wrote: >> ... >>> Fair Enough. I'd thought 0xffff was the magic number :). However, you >>> raise a good point. >>> >>> Grep tells me all the xflags are actually unused. So we could use it, >>> but after chatting with Scott Long, I'm not sure that we should. >>> >>> However, I think Jim's idea of having a separate command for commands >>> for the I/O queue and commands for the admin queue might be the better >>> part of valor here. I'd initially read Jim's mail as use #defines for >>> the xflags values, but that's not at all what he was saying. >>> >>> The code change would be a bit bigger, but not by a lot. It's super >>> easy to add new XPT_ function code. >> >> OK, I'll head down that path and add a new XPT opcode XPT_NVME_ADMIN >> and helper macro cam_fill_nvmeadmin() which would be used for Admin >> commands. The existing XPT_NVME_IO would be used for NVM/IO commands. >> Both opcodes would use the ccb_nvmeio structure unless there are >> objections .... ? > > Seems reasonable to me. Me too.