From owner-freebsd-hackers@freebsd.org Sun Mar 24 09:01:18 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A8561551619; Sun, 24 Mar 2019 09:01:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3FF55730DE; Sun, 24 Mar 2019 09:01:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x2O914lC009017 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 24 Mar 2019 11:01:07 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x2O914lC009017 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x2O913nC009016; Sun, 24 Mar 2019 11:01:03 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 24 Mar 2019 11:01:03 +0200 From: Konstantin Belousov To: Rebecca Cran Cc: FreeBSD Hackers , arch@freebsd.org Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" Message-ID: <20190324090103.GO1923@kib.kiev.ua> References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 09:01:18 -0000 On Sat, Mar 23, 2019 at 08:21:43PM -0600, Rebecca Cran via freebsd-hackers wrote: > I've been working on EFI support, and have a review > (https://reviews.freebsd.org/D19588) to add a script, efi-update-loader, > which will update the ESP containing the FreeBSD boot1.efi or loader.efi. > > I'd like to integrate it into the build system so it gets run when users > do a "make installworld", but I'm lost looking through Makefile.inc1 - I > have no clue where to add the code. > > Does anyone understand where and what to add? Can we take use of the opportunity and finally stop installing loader at installworld target at all, please ? Add e.g. installloader target which would do whatever needed to loader.