From owner-freebsd-ports@FreeBSD.ORG Sun Oct 7 11:58:21 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5536B16A468 for ; Sun, 7 Oct 2007 11:58:21 +0000 (UTC) (envelope-from lars.stokholm@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.177]) by mx1.freebsd.org (Postfix) with ESMTP id 2EB5113C48E for ; Sun, 7 Oct 2007 11:58:21 +0000 (UTC) (envelope-from lars.stokholm@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1319894waf for ; Sun, 07 Oct 2007 04:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=yJKxsdhN7zj7c4y2sPHBv8Z1XVgx5RaXxbFiuOOIHQY=; b=drwM6R2E4L4RhRhktwVUb7sF1lCkzgXw0G8X/CyndresgE7oRJZ4tK8dTFbfUDyUrvRYJ8OE4T6RYpJuSqOifkoPKGKjn6gVoBpiAqTQyf4T5Sva5udayfRczHYYpWfFzYD64NSJ6MqCcfgBJ+gd4S/SIj/sxHDArLl0/TSM2+s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DYNoF0mFOFtmqe3lh9pNhW1sO/ssdAkEC8o5/kyCpd7Hy7wnnks7bzhE86HolesgcMdQHIoF/K39nmj3TWWcIJhHEhHZ6D8bj6EcLHWtlGXoKEafCA4eGgnDzlzfa1QJf7413z+zjBb8qcW/J9gfuANaUr+0+rxdpiZBXjW/cF0= Received: by 10.114.130.1 with SMTP id c1mr5009009wad.1191758300766; Sun, 07 Oct 2007 04:58:20 -0700 (PDT) Received: by 10.115.92.6 with HTTP; Sun, 7 Oct 2007 04:58:20 -0700 (PDT) Message-ID: Date: Sun, 7 Oct 2007 13:58:20 +0200 From: "Lars Stokholm" To: "Doug Barton" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <790a9fff0710051337j710e5f97w809ce08998884648@mail.gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Has portmaster gone insane? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2007 11:58:21 -0000 On 10/7/07, Doug Barton wrote: > On Fri, 5 Oct 2007, Lars Stokholm wrote: > > On 10/5/07, Scot Hetzel wrote: > >> On 10/5/07, Lars Stokholm wrote: > >>> Running 'portmaster --clean-distfiles-all' it began to delete *a lot* > >>> of files it shouldn't. I haven't had time to see how much is missing, > >>> but I guess is so much, that the entire installation is screwed. > > I'm sincerely sorry that you've had this problem. I think Scot is right i= n > that the code for --clean-distfiles* is pretty simple, and relies totally > on a proper definition of DISTDIR. Perhaps at the time it was empty, but it isn't now. I tried what Scot said and it gave me "/usr/ports/distfiles". I also ran "portmaster --clean-distfiles-all" again and it completed as expected, deleting a few disftiles, but nothing else. Also, I'm not completely sure, but it seems like it has only deleted stuff in my ~, that is nothing outside of ~lars. It has probably got something to do with the fact that I su'd from lars to root, likely without cd'ing to somewhere else, when I ran clean-distfiles-all the other day. > I think I can see _what_ is happening, although I can't tell you why it's > happening. Somehow the definition of DISTDIR on your system is empty, and > so it's starting the find in / instead of /usr/ports/distfiles as it > should. I'll add a check for empty DISTDIR and roll it into an update I'm > working on at the moment. > > >>> It choked on a filename of a weird charset, so it didn't get a chance > >>> to delete everything. > > I'm not sure I understand what you mean here, but I'm glad to hear that i= t > didn't delete everything. Can you please try the attached patch and tell > me if you get the error? What I meant was just that it stopped deleting files (for some reason), when it got to a file I have, originally called "STUDIEFORL=D8BSBESKRIVELSE". At some point in time the "=D8" in the file name was replaced by "??" and a lot of programs choke on that. It probably hasn't got anything to do with portmaster anyway. :) > >> Portmaster uses the following to determine the value of DISTDIR. What > >> does this show that DISTDIR is set to? > >> > >> make BEFOREPORTMK=3Dyes -f/usr/share/mk/bsd.port.mk -V DISTDIR > > > > I'll have a look tomorrow. > > I'm very interested in the results here. I finally got around to having a look at it. It wouldn't make much sense to try the patch now that DISTDIR isn't empty (anymore?), but if there's anything else I can do, I'll do it. By the way, I had backup of everything, so nothing is lost. :)