Date: Tue, 25 Sep 2001 13:48:49 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: parv <parv_@yahoo.com> Cc: f-ports <freebsd-ports@FreeBSD.org> Subject: Re: package problem w/ sawfish Message-ID: <3BB06111.E855551C@FreeBSD.org> References: <20010921212527.A19766@moo.holy.cow>
next in thread | previous in thread | raw e-mail | index | archive | help
Heh, I've already told you several times that you can't make arbitrary changes in the port's makefile and expect that it will "just work". I would like to suggest you to obtain some glue about how the ports system works first (for
example, read Porter's Handbook) and then look back at your changes to find why it was failing.
-Maxim
parv wrote:
> before i contemplate to file a pr, i want to confirm if it's worth the
> effort.
>
> following are the changes made to the Makefile; as it stands one get
> the impression that there shouldn't be any further user intervention.
>
> --- Makefile--old Tue Aug 28 12:48:30 2001
> +++ Makefile Fri Sep 21 21:13:57 2001
> @@ -23,7 +23,7 @@
> USE_X_PREFIX= yes
> USE_GMAKE= yes
> USE_IMLIB= yes
> -WANT_GNOME= yes
> +#WANT_GNOME= yes
> GNU_CONFIGURE= yes
> CONFIGURE_ARGS= --with-readline \
> --localstatedir=${PREFIX}/share \
> @@ -33,16 +33,16 @@
>
> .include <bsd.port.pre.mk>
>
> -.if defined(HAVE_GNOME)
> -USE_GNOME= yes
> -CONFIGURE_ARGS+=--enable-capplet
> -PLIST_SUB+= GNOME:=""
> -.else
> +#.if defined(HAVE_GNOME)
> +#USE_GNOME= yes
> +#CONFIGURE_ARGS+=--enable-capplet
> +#PLIST_SUB+= GNOME:=""
> +#.else
> CONFIGURE_ARGS+=--disable-capplet \
> --disable-gnome-widgets \
> --without-gdk-pixbuf
> PLIST_SUB+= GNOME:="@comment "
> -.endif
> +#.endif
>
> pre-patch:
> @${PERL} -pi -e 's^-l(pthread|c_r)^${PTHREAD_LIBS}^g ; \
>
> ...given the above changes, should i file a pr or is the package problem
> expected? i assumed that CONFIGURE_ARGS & PLIST_SUB variables would
> have taken care of the packaging list.
>
> thanks much.
>
> here is the error message...
>
> ===> Building package for sawfish-1.0_1
> Creating package /source/ports/x11-wm/sawfish/sawfish-1.0_1.tgz
> Registering depends: XFree86-libraries-4.1.0 imlib-1.9.11 rep-gtk-0.15_1 gtk-1.2.10_2 glib-1.2.10_4 librep-0.14 imake-4.1.0 libungif-4.1.0b1 tiff-3.5.5 gdbm-1.8.0 freetype2-2.0.4 pkgconfig-0.8.0 png-1.2.0 gettext-0.10.35 jpeg-6b.
> Creating gzip'd tar ball in '/source/ports/x11-wm/sawfish/sawfish-1.0_1.tgz'
> tar: can't add file %%NOGNOME:%%@dirrm share/gnome/pixmaps : No such file or directory
> tar: can't add file %%NOGNOME:%%@dirrm share/gnome : No such file or directory
> pkg_create: make_dist: tar command failed with code 256
> *** Error code 1
>
> Stop in /source/ports/x11-wm/sawfish.
> *** Error code 1
>
> - parv
>
> --
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BB06111.E855551C>