From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 21 12:10:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67AEF10656A6 for ; Mon, 21 Sep 2009 12:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 88FD28FC16 for ; Mon, 21 Sep 2009 12:10:02 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8LCA238096279 for ; Mon, 21 Sep 2009 12:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8LCA2oA096278; Mon, 21 Sep 2009 12:10:02 GMT (envelope-from gnats) Resent-Date: Mon, 21 Sep 2009 12:10:02 GMT Resent-Message-Id: <200909211210.n8LCA2oA096278@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Jeremy Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6FCA10656A6 for ; Mon, 21 Sep 2009 12:01:26 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au [211.29.132.197]) by mx1.freebsd.org (Postfix) with ESMTP id C9BD28FC13 for ; Mon, 21 Sep 2009 12:01:25 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c122-106-250-30.belrs3.nsw.optusnet.com.au [122.106.250.30]) by mail16.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n8LC1NEM026203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 21 Sep 2009 22:01:24 +1000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id n8LC1MPH017860; Mon, 21 Sep 2009 22:01:22 +1000 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id n8LC1MFD017859; Mon, 21 Sep 2009 22:01:22 +1000 (EST) (envelope-from peter) Message-Id: <200909211201.n8LC1MFD017859@server.vk2pj.dyndns.org> Date: Mon, 21 Sep 2009 22:01:22 +1000 (EST) From: Peter Jeremy To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/139011: [patch] Add options to support GLX TLS in x11-servers/xorg-server X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Jeremy List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2009 12:10:03 -0000 >Number: 139011 >Category: ports >Synopsis: [patch] Add options to support GLX TLS in x11-servers/xorg-server >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 21 12:10:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Peter Jeremy >Release: FreeBSD 8.0-BETA4 amd64 >Organization: n/a >Environment: System: FreeBSD server.vk2pj.dyndns.org 8.0-BETA4 FreeBSD 8.0-BETA4 #1: Fri Sep 18 09:11:01 EST 2009 root@server.vk2pj.dyndns.org:/tank/obj/usr/src/sys/server amd64 >Description: The X.org 7.4 server expects to be multi-threaded but unless it is compiled with HAL enabled, it will not link against libpthread. Whilst this does not cause compilation errors, it will result in various runtime anomolies - the exact problems depend on the specific driver but the Intel driver is particularly badly affected. Enabling GLX Thread Local Storage appears to be the correct work-around for this issue. >How-To-Repeat: Build xorg-server without HAL and use with an Intel driver on (eg) i945 GPU. Switch to/from VTYs and watch the display break. >Fix: Index: x11-servers/xorg-server/Makefile =================================================================== RCS file: /usr/ncvs/ports/x11-servers/xorg-server/Makefile,v retrieving revision 1.73 diff -u -r1.73 Makefile --- x11-servers/xorg-server/Makefile 19 Jun 2009 23:19:01 -0000 1.73 +++ x11-servers/xorg-server/Makefile 20 Jun 2009 14:32:10 -0000 @@ -7,6 +7,7 @@ PORTNAME= xorg-server PORTVERSION= 1.6.1 +PORTREVISION= 1 PORTEPOCH= 1 CATEGORIES= x11-servers MASTER_SITES= http://xorg.freedesktop.org/releases/individual/xserver/ @@ -50,6 +51,7 @@ OPTIONS= HAL "Compile with HAL config support" on \ AIGLX "Compile with Accelerated Indirect GLX support" on \ + GLX_TLS "Compile with GLX Thread Local Storage" on \ SUID "Install the Xorg server with setuid bit set" on .include @@ -74,6 +76,12 @@ CONFIGURE_ARGS+= --enable-aiglx=no .endif +.if !defined(WITHOUT_GLX_TLS) +CONFIGURE_ARGS+= --enable-glx-tls=yes +.else +CONFIGURE_ARGS+= --enable-glx-tls=no +.endif + .if !defined(WITHOUT_SUID) && (!defined(NO_SUID_XSERVER) || ${NO_SUID_XSERVER} == NO) CONFIGURE_ARGS+=--enable-install-setuid=yes .else >Release-Note: >Audit-Trail: >Unformatted: