From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 19 20:40:04 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EFAB106566C for ; Sat, 19 Dec 2009 20:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 52D718FC18 for ; Sat, 19 Dec 2009 20:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nBJKe4Pv028928 for ; Sat, 19 Dec 2009 20:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nBJKe4bS028927; Sat, 19 Dec 2009 20:40:04 GMT (envelope-from gnats) Resent-Date: Sat, 19 Dec 2009 20:40:04 GMT Resent-Message-Id: <200912192040.nBJKe4bS028927@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Max Brazhnikov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5D4C1065679 for ; Sat, 19 Dec 2009 20:33:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id D52FE8FC0C for ; Sat, 19 Dec 2009 20:33:02 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBJKX2ui015793 for ; Sat, 19 Dec 2009 20:33:02 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nBJKX2MC015792; Sat, 19 Dec 2009 20:33:02 GMT (envelope-from nobody) Message-Id: <200912192033.nBJKX2MC015792@www.freebsd.org> Date: Sat, 19 Dec 2009 20:33:02 GMT From: Max Brazhnikov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/141785: deskutils/google-gadgets: fix Qt4 usage X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Dec 2009 20:40:04 -0000 >Number: 141785 >Category: ports >Synopsis: deskutils/google-gadgets: fix Qt4 usage >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Dec 19 20:40:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Max Brazhnikov >Release: FreeBSD 8.0-STABLE i386 >Organization: >Environment: FreeBSD luna.dio.ru 8.0-STABLE FreeBSD 8.0-STABLE #2: Fri Dec 4 17:55:41 MSK 2009 makc@luna.dio.ru:/usr/obj/usr/freebsd/8/src/sys/LUNA i386 >Description: 1) USE_* must be used before bsd.port.pre.mk (see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html#AEN2441 ), fix this 2) improve IGNORE message >How-To-Repeat: >Fix: Patch attached with submission follows: Index: ports/deskutils/google-gadgets/Makefile =================================================================== RCS file: /home/pcvs/ports/deskutils/google-gadgets/Makefile,v retrieving revision 1.13 diff -u -r1.13 Makefile --- ports/deskutils/google-gadgets/Makefile 2 Aug 2009 19:32:54 -0000 1.13 +++ ports/deskutils/google-gadgets/Makefile 19 Dec 2009 19:34:03 -0000 @@ -48,10 +48,16 @@ GTK "Build GTK Host" on\ QT "Build Qt Host" on +.include +.if defined(WITH_QT) +USE_QT_VER= 4 +QT_COMPONENTS= webkit opengl gui corelib script network moc_build +.endif + .include .if ${OSVERSION} < 700000 -IGNORE=This port needs 7.X or higher +IGNORE= needs 7.X or higher .endif .if defined(WITH_DEBUGGING) @@ -74,14 +80,12 @@ CONFIGURE_ARGS+= --disable-qt-host --disable-libggadget-qt --disable-qt-system-framework\ --disable-qtwebkit-browser-element --disable-qt-script-runtime --disable-qt-xml-http-request .else -USE_QT_VER= 4 -QT_COMPONENTS= webkit opengl gui corelib script network moc PLIST_SUB+= QT="" CONFIGURE_ARGS+= --enable-qt-host .endif .if defined(WITHOUT_QT) && defined(WITHOUT_GTK) -IGNORE=This port requires GTK or Qt host to be enabled +IGNORE= requires GTK or/and Qt host to be enabled. Please, rerun 'make config' .endif post-patch: >Release-Note: >Audit-Trail: >Unformatted: