From owner-freebsd-current@FreeBSD.ORG Fri Jan 18 13:26:35 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E9624BF; Fri, 18 Jan 2013 13:26:35 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by mx1.freebsd.org (Postfix) with ESMTP id 9996B81D; Fri, 18 Jan 2013 13:26:34 +0000 (UTC) Received: by mail-bk0-f46.google.com with SMTP id q16so2024454bkw.19 for ; Fri, 18 Jan 2013 05:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=dLNygEFn0AjhS3K2QkqS1Oi9ORCYYsUDQz4qvKQyI40=; b=ADYDYamILmn1Po5rrFnB+90X2ia9yhasMPi/ES/tUdfnqEbRHpQeo+n3/qXtKKatfI eRj+a01hbobREbmJDBcS79qlh68tx483l1oSufGFy1E33dXgTFMUkEnmRFLS/yL1nrZQ 60Z1WpP97cQKTaBBrU2fxu6JUTn1PBauIM0QXSndJisw0rIb7xkZuhK/mkJ+KE83hBzH 1ZQe/gHqGWzd2vnOIuInK2i26ZVc3RfvTsBK+gECuJAnwm5p2tA188IuhqC7xE5u3dOY dPOq4rKo7WXg1YYax5IcQT8wWADcAWpgPjtKYyNpQVrorDUkhQtcIMUnoj5soEGpG6bk PnuA== X-Received: by 10.204.148.134 with SMTP id p6mr2453836bkv.75.1358515588382; Fri, 18 Jan 2013 05:26:28 -0800 (PST) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id f24sm3825786bkv.7.2013.01.18.05.26.25 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jan 2013 05:26:27 -0800 (PST) Sender: Alexander Motin Message-ID: <50F94D80.7000809@FreeBSD.org> Date: Fri, 18 Jan 2013 15:26:24 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Jaakko Heinonen Subject: Re: panic after r244584 References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Justin T. Gibbs" , satan@ukr.net, Gleb Smirnoff , freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2013 13:26:36 -0000 On 18.01.2013 15:19, Jaakko Heinonen wrote: > On 2013-01-18, Alexander Motin wrote: >>> AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) > >>> AM> The panic is triggered by the check added by the recent r244584 change. >>> AM> The space in device name came from the enclosure device, and I guess it >>> AM> may be quite often situation. Using human readable name supposed to help >>> AM> system administrators, but with spaces banned that may be a problem. >>> >>> That's was not created by human, it was generated (I think so) by system. >> >> These strings are flashed into enclosure firmware by manufacturer. > > You can't rely on that any string can be safely used as a device name > even if spaces were allowed. Consider for example duplicate names and > "../". > > Where these names are generated? The original report didn't contain a > backtrace. At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are impossible there, as previous name components are unique. Special characters haven't yet seen, but I think theoretically possible. Interesting what Solaris does in such cases, mangles them somehow or removes completely? -- Alexander Motin