From owner-cvs-src@FreeBSD.ORG Thu Feb 1 09:46:05 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 319A616A402; Thu, 1 Feb 2007 09:46:05 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 2113D13C4A3; Thu, 1 Feb 2007 09:46:05 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l119k5Jd049444; Thu, 1 Feb 2007 09:46:05 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l119k4oO049443; Thu, 1 Feb 2007 09:46:04 GMT (envelope-from ariff) Message-Id: <200702010946.l119k4oO049443@repoman.freebsd.org> From: Ariff Abdullah Date: Thu, 1 Feb 2007 09:46:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pcm buffer.c buffer.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2007 09:46:05 -0000 ariff 2007-02-01 09:46:03 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm buffer.c buffer.h Log: Fix huge memory leak within sound buffer (during channel destruction, buffer resizing, etc.) that was here since eon. Free all (unmanaged) allocated buffer through sndbuf_destroy() in case we forgot to call sndbuf_free(). For a managed buffer (mostly hw specific managed buffer), either provide CHANNEL_FREE() method with appropriate return value to invoke semi-automatic sndbuf_free() or simply do it on their own. If everything is failed, sndbuf_destroy() will come to the rescue as a final measure. MFC after: 3 days Revision Changes Path 1.30 +12 -0 src/sys/dev/sound/pcm/buffer.c 1.14 +1 -0 src/sys/dev/sound/pcm/buffer.h