Date: Thu, 19 Apr 2012 20:03:38 +0200 From: =?ISO-8859-1?Q?Fernando_Apestegu=EDa?= <fernando.apesteguia@gmail.com> To: Chris Rees <utisoft@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Question about PORTEXAMPLES Message-ID: <CAGwOe2bz3JyLDV8rGdvWpsmOMV1Wb7keGSBFHXN9PTHHZTDaXw@mail.gmail.com> In-Reply-To: <CADLo83-e7XGweFoMxPt7Bq%2BSCUBWejTk6VyCnBVqciX2tOQF6g@mail.gmail.com> References: <CAGwOe2YW_LB9Yfyr4Q=s0QAvcvUtgjopP-aBQqufY7imoxUqyw@mail.gmail.com> <CADLo83_8ew5kH%2BRhv4LDQjburNzwSKbQc2mhWhPn2UXnic_gmw@mail.gmail.com> <CAGwOe2YgFoT%2BEqXWt64=Yedrhrbr3LGBd3DSpYJ=i8koT%2B6dog@mail.gmail.com> <CADLo83-e7XGweFoMxPt7Bq%2BSCUBWejTk6VyCnBVqciX2tOQF6g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 19, 2012 at 7:43 PM, Chris Rees <utisoft@gmail.com> wrote:
> On 19 April 2012 17:46, Fernando Apestegu=EDa
> <fernando.apesteguia@gmail.com> wrote:
>> On Wed, Apr 18, 2012 at 7:32 PM, Chris Rees <utisoft@gmail.com> wrote:
>>>
>>> On 18 Apr 2012 18:05, "Fernando Apestegu=EDa" <fernando.apesteguia@gmai=
l.com>
>>> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I'm working on the port for OpenVSP. Here[1] there is a preliminary
>>>> version.
>>>>
>>>> scheidell suggests simplifying the port using PORTEXAMPLES. I redid th=
e
>>>> Makefile
>>>> a little so it looks like this now (I show only the relevant part):
>>>>
>>>> PORTEXAMPLES=3D =A0 ${WRKSRC}/../examples/airfoil/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/cabin/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/fonts/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/fuselage/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/models/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/setup/*
>>>> PORTEXAMPLES+=3D =A0${WRKSRC}/../examples/textures/*
>>>>
>>>> PLIST_FILES=3D =A0 =A0bin/vsp
>>>>
>>>> do-fetch:
>>>> =A0 =A0 =A0 =A0${FETCH_BINARY} -o ${DISTDIR}/${DISTNAME}.tar.gz
>>>> ${MASTER_SITES}${DISTNAME}
>>>>
>>>> do-install:
>>>> =A0 =A0 =A0 =A0@${INSTALL_PROGRAM} ${WRKSRC}/vsp/vsp ${PREFIX}/bin
>>>> .if !defined(NOPORTEXAMPLES)
>>>> .for i in airfoil cabin fonts fuselage models setup textures
>>>> =A0 =A0 =A0 =A0@${MKDIR} ${EXAMPLESDIR}/${i}
>>>> =A0 =A0 =A0 =A0@${INSTALL_DATA} ${WRKSRC}/../examples/${i}/* ${EXAMPLE=
SDIR}
>>>> .endfor
>>>> .endif
>>>>
>>>> portlint -abt only complains about one single MASTER_SITE configured
>>>> (nothing I can do
>>>> about it).
>>>>
>>>> However, 'port test' shows the following:
>>>>
>>>> =3D=3D=3D> =A0 Deinstalling openvsp-2.0
>>>> pkg_delete: unable to completely remove directory
>>>> '/tmp/openvsp-2.0/share/examples/openvsp'
>>>> pkg_delete: couldn't entirely delete package `openvsp-2.0'
>>>> (perhaps the packing list is incorrectly specified?)
>>>>
>>>> I don't get why this happens. What I want is to keep the same
>>>> hierarchy the package has. This is,
>>>> having the subdirectories 'airfoil', 'cabin', etc. hanging from the
>>>> port's EXAMPLESDIR.
>>>>
>>>> Any help is appreciated.
>>>>
>>>> Cheers.
>>>>
>>>> PS: Please, CC me as I'm not subscribed to the list. Thanks!
>>>>
>>>> [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=3D166825
>>>>
>>>
>>> PORTEXAMPLES=3D* will work fine for the plist; don't use PORTEXAMPLES i=
n the
>>> for loop.
>>
>> I changed to PORTEXAMPLES=3D${WRKSRC}/../examples/*
>> this handles the whole tree hierarchy.
>
> Hm, that's actually incorrect. =A0PORTEXAMPLES should be relative to EXAM=
PLESDIR.
>
>> I don't see the other thing... I'm not using PORTEXAMPLES in the loop.
>> I'm traversing
>> all the examples directories to create them and install the files with
>> INSTALL_DATA.
>> Is it possible to install the whole hierarchy at once?
>> I saw the following line in /usr/ports/audio/hs-ALUT
>>
>> INSTALL_PORTEXAMPLES=3D =A0 @(cd ${WRKSRC}/examples/ && ${COPYTREE_SHARE=
}
>> \* ${EXAMPLESDIR})
>>
>> and then use it this way:
>>
>> .if !defined(NOPORTEXAMPLES)
>> =A0 =A0 =A0 =A0@${MKDIR} ${EXAMPLESDIR}
>> =A0 =A0 =A0 =A0@${INSTALL_PORTEXAMPLES}
>> .endif
>>
>>>
>>> Your problem is that you aren't removing the subdirs below EXAMPLESDIR.
>>
>> Should I delete them by hand or is there a way to mark the
>> PORTEXAMPLES hierarchy to be wiped out?
>>
>
> No, just use PORTEXAMPLES=3D* as I suggested before :)
And... you're absolutely right :)
Now port test reports no errors.
Thank you!
>
> Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2bz3JyLDV8rGdvWpsmOMV1Wb7keGSBFHXN9PTHHZTDaXw>