From owner-freebsd-bugs@freebsd.org  Thu Mar  9 17:11:40 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E4C6D04826
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Thu,  9 Mar 2017 17:11:40 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F249F1DCF
 for <freebsd-bugs@FreeBSD.org>; Thu,  9 Mar 2017 17:11:39 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v29HBdDb094600
 for <freebsd-bugs@FreeBSD.org>; Thu, 9 Mar 2017 17:11:39 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 217667] arp "moved" log message gives incorrect "from" MAC
Date: Thu, 09 Mar 2017 17:11:40 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: andrew@tao11.riddles.org.uk
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-217667-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Mar 2017 17:11:40 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217667

            Bug ID: 217667
           Summary: arp "moved" log message gives incorrect "from" MAC
           Product: Base System
           Version: 11.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: andrew@tao11.riddles.org.uk

The ARP "x moved from y to z" log message in if_ether.c is mistakenly taking
the address of the char* which points to the previous MAC address, rather t=
han
taking the pointer value; thus the reported former MAC address is garbage.

For example these two messages were the result of swapping a device out and
then back (actual IP redacted):

kernel: arp: x.x.x.x moved from 18:8d:69:c6:00:00 to 14:cc:20:09:a6:50 on
ue0.10
kernel: arp: x.x.x.x moved from 18:8d:69:c6:00:00 to 00:26:44:17:90:e1 on
ue0.10

ll_addr is a char*, not a char[], so:

  (u_char *)&la->ll_addr

should be

  (u_char *)la->ll_addr

--=20
You are receiving this mail because:
You are the assignee for the bug.=