Date: Tue, 12 Feb 2019 08:21:05 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Dmitry Morozovsky <marck@freebsd.org> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs Message-ID: <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <alpine.BSF.2.00.1902121808080.2716@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 12 Feb 2019, Cy Schubert wrote: > > > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry > > Morozovsky wr > > ites: > > > Author: marck (doc committer) > > > Date: Tue Feb 12 13:58:16 2019 > > > New Revision: 344051 > > > URL: https://svnweb.freebsd.org/changeset/base/344051 > > > > > > Log: > > > MFC 343548: > > > > > > Allow dashes as a valid character in UFS labels. > > > > Approved by: Whom? > > Sorry, I missed commit log metadata from the original change. > > Lesson learnt. I think your fine on how you did this, I certainly already knew from reading the ^head commits that this change had infact been approved by Kirk, and had been flagged for MFC. I do not see value in duplicationg all that info in the stable branches, but perhaps we should formalize that in the committers guide on commit messages? -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902121621.x1CGL5dq076678>