Date: Fri, 11 Oct 2019 01:23:11 -0700 From: Conrad Meyer <cem@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: Andriy Gapon <avg@freebsd.org>, Brooks Davis <brooks@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r353408 - head Message-ID: <CAG6CVpU7hwe%2BCiH7x_25XfXzbpLEov8UBHtf-ssCEshcTwARLw@mail.gmail.com> In-Reply-To: <137352B5-82C6-4953-9233-282A92FCAFC8@FreeBSD.org> References: <201910101629.x9AGTDkJ024957@repo.freebsd.org> <CAG6CVpUdL297XdaW96mC7Jcgo=wk2JpZB9k=9-hFDQkEMR8T2A@mail.gmail.com> <1ba0202e-698d-7cc4-1907-59d75cfe4332@FreeBSD.org> <137352B5-82C6-4953-9233-282A92FCAFC8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
That might be the problem in the CI rig, but xtoolchain on CURRENT doesn't appear to provide the incorrect "12" value, and it's still broken =E2=80=94 nothing to do with gets(3). $ x86_64-unknown-freebsd13.0-gcc-6.4.0 -std=3Dc99 -dM -E - < /dev/null | grep FreeBSD #define __FreeBSD__ 13 The error I hit is the one ostensibly fixed by 353408: make[4]: /obj/usr/home/conrad/src/freebsd/amd64.amd64/sys/GENERIC/modules/u= sr/home/conrad/src/freebsd/sys/modules/opensolaris/.depend.opensolaris_atom= ic.o, 5: ignoring stale .depend for /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd= 64/opensolaris_atomic.S x86_64-unknown-freebsd13.0-gcc: error: /usr/home/conrad/src/freebsd/sys/cddl/contrib/opensolaris/common/atomic/amd= 64/opensolaris_atomic.S: No such file or directory x86_64-unknown-freebsd13.0-gcc: fatal error: no input files Best, Conrad On Fri, Oct 11, 2019 at 1:04 AM Dimitry Andric <dim@freebsd.org> wrote: > > On 11 Oct 2019, at 08:24, Andriy Gapon <avg@FreeBSD.org> wrote: > > > > On 11/10/2019 09:07, Conrad Meyer wrote: > >> Fwiw, this doesn=E2=80=99t seem to fix the NO_CLEAN build for amd64-xt= oolchain-gcc. > > > > Does a clean build work for that configuration? > > I looked at one of CI builds and it had this: > > In file included from /workspace/src/contrib/libc++/include/__debug:26:= 0, > > from /workspace/src/contrib/libc++/include/utility:206, > > from /workspace/src/contrib/libc++/include/algorithm:64= 2, > > from /workspace/src/contrib/libc++/src/algorithm.cpp:9: > > /workspace/src/contrib/libc++/include/cstdio:156:9: error: '::gets' has= not been > > declared > > using ::gets; > > > > I recall seeing a similar problem for riscv too. > > Yes, this is an issue with the external toolchains, which pass the wrong > version of __FreeBSD__. They should set the value to 13, not 12. > > -Dimitry >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpU7hwe%2BCiH7x_25XfXzbpLEov8UBHtf-ssCEshcTwARLw>