Date: Thu, 14 Nov 2002 19:27:27 +0100 (CET) From: Soeren Schmidt <sos@spider.deepcore.dk> To: Bruce Evans <bde@zeta.org.au> Cc: Conrad Sabatier <conrads@cox.net>, freebsd-current@FreeBSD.ORG, freebsd-multimedia@FreeBSD.ORG Subject: Re: /dev/acd*t* no longer available in -current? Message-ID: <200211141827.gAEIRRQG026591@spider.deepcore.dk> In-Reply-To: <20021115011200.E10490-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
It seems Bruce Evans wrote: > Single-digit track numbers are correct and are still generated by MAKEDEV. Single digit track numbers are wrong and should be fixed in MAKEDEV. > The devfs numbers were broken in: > > % RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v > % Working file: atapi-cd.c > % head: 1.126 > % ... > % ---------------------------- > % revision 1.119 > % date: 2002/05/28 17:39:17; author: sos; state: Exp; lines: +1 -1 > % Use %02d in track numbers, so that 1 is 01, much easier for scripts > % ---------------------------- > > Contrary to the log message, %02d is harder for scripts. It gives many > more cases to handle: > - %d format under RELENG_4 Should be fixed. > - %d format under -current in the non-devfs case DEVFS should be considered mandatory for the track devices on current. > - %d format under -current even in the devfs case for track numbers >= 100 BZZT!! there can be a max of 99 tracks on a CD. > - %02d under -current in the devfs case for track numbers < 100. Thats actually the one thats right :) > The following patch backs out rev.1.119 of atapi-cd.c and fixes the > following older devfs bugs in acd: > - insecure permissions. Among other holes, these allowed the world to > erase cd-rw's. Use rc.devfs for that as it was intended. > - hard-coded ownerships leading to broken groups for the track devices. Well, that sounds like a bug alright... -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-multimedia" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211141827.gAEIRRQG026591>