Date: Mon, 11 Jun 2012 16:26:42 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Warren Block <wblock@wonkity.com> Cc: ports@freebsd.org, Jason Helfman <jhelfman@e-e.com> Subject: Re: NOPORTDOCS and NOPORTEXAMPLES Message-ID: <20120611142642.GZ60433@ithaqua.etoilebsd.net> In-Reply-To: <alpine.BSF.2.00.1206110809350.82724@wonkity.com> References: <alpine.BSF.2.00.1206101408330.77586@wonkity.com> <f5dc8813da21631bff52d1017bcd6dcf.squirrel@mail.experts-exchange.com> <alpine.BSF.2.00.1206101736170.78656@wonkity.com> <20120611051759.GQ60433@ithaqua.etoilebsd.net> <alpine.BSF.2.00.1206110755001.82724@wonkity.com> <20120611140725.GY60433@ithaqua.etoilebsd.net> <alpine.BSF.2.00.1206110809350.82724@wonkity.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--5FDiZl1vRbLRjwwc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 11, 2012 at 08:17:08AM -0600, Warren Block wrote: > On Mon, 11 Jun 2012, Baptiste Daroussin wrote: >=20 > >> The logic has probably gotten twisted around, and it's been long enough > >> since I did this that I don't recall the situation. I think it was ju= st > >> to prevent the options screen from appearing if NOPORTDOCS and > >> NOPORTEXAMPLES were set. > >> > >> I don't see a way to do that without using the old versions of those > >> variables. The new ones have not been set until after > >> bsd.port.options.mk is included, and by then the dialog has been shown. > > > > Do not put OPTIONS_DEFINE and you won't get a dialog UI but still can t= est > > PORT_OPTIONS:MEXAMPLES and PORT_OPTIONS:MDOCS >=20 > The original: >=20 > .if !defined(NOPORTDOCS) > OPTIONS+=3D REFDOCS "Install the reference documents" on > .endif > .if !defined(NOPORTEXAMPLES) > OPTIONS+=3D EXAMPLES "Install the example code" on > .endif >=20 > .include <bsd.port.options.mk> >=20 > So if the user has set NOPORTDOCS in make.conf, that option does not=20 > appear in the dialog. Likewise with NOPORTEXAMPLES, and if both are=20 > set, the dialog does not appear at all. >=20 > If either docs or examples are allowed, the user gets the chance to turn= =20 > them off for this port. While I understand it is not consistent and doesn't make much sense. It had sense at the time of the old framework because the old framework wasn't consistent, ie: NOPORTDOCS in make.conf had no effect on the default dialog. But now it is consistent NOPORTDOCS disable DOCS by default. but maybe the = use want to set it on for that particular package. regards, Bapt --5FDiZl1vRbLRjwwc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/WACIACgkQ8kTtMUmk6ExNwgCgsT4OPDAo8zN9RIV2Y8ifILlU d8MAoIPLb9dimAfb39hG3v33UavN9Y6l =N5+R -----END PGP SIGNATURE----- --5FDiZl1vRbLRjwwc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120611142642.GZ60433>