Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Feb 2016 15:39:18 -0600
From:      Eric van Gyzen <vangyzen@FreeBSD.org>
To:        Konstantin Belousov <kostikbel@gmail.com>, threads@freebsd.org, arch@freebsd.org
Subject:   Re: libthr shared locks
Message-ID:  <56C24586.9050906@FreeBSD.org>
In-Reply-To: <56BE69B8.9020808@FreeBSD.org>
References:  <20151223172528.GT3625@kib.kiev.ua> <56BE69B8.9020808@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 02/12/16 05:24 PM, Eric van Gyzen wrote:
> On 12/23/2015 11:25, Konstantin Belousov wrote:
>> The implementation in the patch
>> https://www.kib.kiev.ua/kib/pshared/pshared.1.patch
>> gives shared mutexes, condvars, rwlocks and barriers.
> I reviewed everything except kern_umtx.c, which I plan to review on
> Monday.

My only comment on kern_umtx.c is, why are the permission checks compiled out?

I also reviewed versions 2 and 3; the revisions look fine.

Thanks for the chance to review, and for waiting for me to find time.

Eric



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56C24586.9050906>