Date: Sun, 9 Feb 2014 18:31:30 -0500 From: Shawn Webb <lattera@gmail.com> To: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= <olivier@cochard.me> Cc: freebsd-bugs@freebsd.org Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel Message-ID: <CADt0fhxP1m4GocFh=hCawjSym0Gxw2DpwSsjbqUd4H_UkqZ4JA@mail.gmail.com> In-Reply-To: <CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54%2BeBOckA@mail.gmail.com> References: <201402042000.s14K01eo021855@freefall.freebsd.org> <CA%2Bq%2BTcpvW3c9c%2B4XJA1MLaMyi5xOSLtjqA5nkPJncGJ%2BJhY2KA@mail.gmail.com> <CADt0fhxWeqkkjVrOG5B2gEN_3kfharkJXudEovVbj54%2BeBOckA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--047d7bf15fde744b4b04f2019fcf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry for the delay. The attached patch should apply cleanly on top of the existing patch and should fix Olivier's problems. On Wed, Feb 5, 2014 at 8:54 AM, Shawn Webb <lattera@gmail.com> wrote: > Looks like that variable is missing in that struct. The exec delta > variable changes how the binary itself and the RTLD is loaded. I'll fix t= he > warnings and errors you reported today. Thanks for helping! > > > On Wed, Feb 5, 2014 at 3:56 AM, Olivier Cochard-Labb=E9 <olivier@cochard.= me>wrote: > >> On Tue, Feb 4, 2014 at 9:00 PM, Shawn Webb <lattera@gmail.com> wrote: >> >>> The following reply was made to PR kern/181497; it has been noted by >>> GNATS. >>> >>> From: Shawn Webb <lattera@gmail.com> >>> To: bug-followup@FreeBSD.org, >>> steven@roothosts.com >>> >>> Cc: >>> Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel >>> Date: Tue, 4 Feb 2014 14:57:44 -0500 >>> >>> --Apple-Mail=3D_70D08D01-527F-4575-806A-36757E957E5A >>> Content-Transfer-Encoding: quoted-printable >>> Content-Type: text/plain; >>> charset=3Dus-ascii >>> >>> I'm sorry, my patch actually wasn't right. It included other fixes I >>> had =3D >>> in my branch for other features and didn't include some of the other = =3D >>> ASLR bits. Attached is the right patch. >>> >>> >> kernel compilation failed if configuration is "with PAX_ASLR options" an= d >> "without COMPAT_FREEBSD32 options": >> >> --- kern_pax.o --- >> /src/sys/kern/kern_pax.c:531:9: error: no member named >> 'vm_aslr_delta_exec' in 'struct vmspace' >> >> vm->vm_aslr_delta_exec =3D round_page(PAX_ASLR_DELTA(arc4random(), >> PAX_ASLR_DELTA_EXEC_LSB, (pr !=3D NULL) ? pr->pr_pax_aslr_exec_len : >> pax_aslr_exec_len)); >> ~~ ^ >> 1 error generated. >> >> What's is this "vm_aslr_delta_exec" ? >> > > --047d7bf15fde744b4b04f2019fcf Content-Type: text/plain; charset=US-ASCII; name="aslr-2014-02-09.patch.txt" Content-Disposition: attachment; filename="aslr-2014-02-09.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hrgy4d3m0 ZGlmZiAtLWdpdCBhL3N5cy9rZXJuL2ltZ2FjdF9lbGYuYyBiL3N5cy9rZXJuL2ltZ2FjdF9lbGYu YwppbmRleCAzZjk0ODdjLi4zYTM2ZjIwIDEwMDY0NAotLS0gYS9zeXMva2Vybi9pbWdhY3RfZWxm LmMKKysrIGIvc3lzL2tlcm4vaW1nYWN0X2VsZi5jCkBAIC02MDMsNyArNjAzLDkgQEAgX19lbGZO KGxvYWRfZmlsZSkoc3RydWN0IHByb2MgKnAsIGNvbnN0IGNoYXIgKmZpbGUsIHVfbG9uZyAqYWRk ciwKIAl1X2xvbmcgcmJhc2U7CiAJdV9sb25nIGJhc2VfYWRkciA9IDA7CiAJaW50IGVycm9yLCBp LCBudW1zZWdzOwotICAgIHN0cnVjdCBwcmlzb24gKnByOyAvKiBGb3IgQVNMUiAqLworI2lmZGVm IFBBWF9BU0xSCisgICAgc3RydWN0IHByaXNvbiAqcHI7CisjZW5kaWYKIAogI2lmZGVmIENBUEFC SUxJVFlfTU9ERQogCS8qCkBAIC02NTksMjIgKzY2MSwyMSBAQCBfX2VsZk4obG9hZF9maWxlKShz dHJ1Y3QgcHJvYyAqcCwgY29uc3QgY2hhciAqZmlsZSwgdV9sb25nICphZGRyLAogCWhkciA9IChj b25zdCBFbGZfRWhkciAqKWltZ3AtPmltYWdlX2hlYWRlcjsKIAlpZiAoKGVycm9yID0gX19lbGZO KGNoZWNrX2hlYWRlcikoaGRyKSkgIT0gMCkKIAkJZ290byBmYWlsOwotCWlmIChoZHItPmVfdHlw ZSA9PSBFVF9EWU4pCisJaWYgKGhkci0+ZV90eXBlID09IEVUX0RZTikgewogCQlyYmFzZSA9ICph ZGRyOwotCWVsc2UgaWYgKGhkci0+ZV90eXBlID09IEVUX0VYRUMpCisjaWZkZWYgUEFYX0FTTFIK KyAgICAgICAgcHIgPSBwYXhfYXNscl9nZXRfcHJpc29uKE5VTEwsIGltZ3AtPnByb2MpOworICAg ICAgICBpZiAocGF4X2FzbHJfYWN0aXZlKE5VTEwsIGltZ3AtPnByb2MpKSB7CisgICAgICAgICAg ICByYmFzZSArPSByb3VuZF9wYWdlKFBBWF9BU0xSX0RFTFRBKGFyYzRyYW5kb20oKSwgUEFYX0FT TFJfREVMVEFfRVhFQ19MU0IsIHByLT5wcl9wYXhfYXNscl9leGVjX2xlbikpOworICAgICAgICB9 CisjZW5kaWYKKyAgICB9IGVsc2UgaWYgKGhkci0+ZV90eXBlID09IEVUX0VYRUMpIHsKIAkJcmJh c2UgPSAwOwotCWVsc2UgeworICAgIH0gZWxzZSB7CiAJCWVycm9yID0gRU5PRVhFQzsKIAkJZ290 byBmYWlsOwogCX0KIAotI2lmZGVmIFBBWF9BU0xSCi0gICAgcHIgPSBwYXhfYXNscl9nZXRfcHJp c29uKE5VTEwsIGltZ3AtPnByb2MpOwotICAgIGlmIChwYXhfYXNscl9hY3RpdmUoTlVMTCwgaW1n cC0+cHJvYykpIHsKLSAgICAgICAgcmJhc2UgKz0gcm91bmRfcGFnZShQQVhfQVNMUl9ERUxUQShh cmM0cmFuZG9tKCksIFBBWF9BU0xSX0RFTFRBX0VYRUNfTFNCLCBwci0+cHJfcGF4X2FzbHJfZXhl Y19sZW4pKTsKLSAgICB9Ci0jZW5kaWYKLQogCS8qIE9ubHkgc3VwcG9ydCBoZWFkZXJzIHRoYXQg Zml0IHdpdGhpbiBmaXJzdCBwYWdlIGZvciBub3cgICAgICAqLwogCWlmICgoaGRyLT5lX3Bob2Zm ID4gUEFHRV9TSVpFKSB8fAogCSAgICAodV9pbnQpaGRyLT5lX3BoZW50c2l6ZSAqIGhkci0+ZV9w aG51bSA+IFBBR0VfU0laRSAtIGhkci0+ZV9waG9mZikgewpkaWZmIC0tZ2l0IGEvc3lzL2tlcm4v a2Vybl9wYXguYyBiL3N5cy9rZXJuL2tlcm5fcGF4LmMKaW5kZXggOTE4MjYwNi4uNzY1NGU1YiAx MDA2NDQKLS0tIGEvc3lzL2tlcm4va2Vybl9wYXguYworKysgYi9zeXMva2Vybi9rZXJuX3BheC5j CkBAIC01MjgsNyArNTI4LDYgQEAgcGF4X2FzbHJfaW5pdChzdHJ1Y3QgdGhyZWFkICp0ZCwgc3Ry dWN0IGltYWdlX3BhcmFtcyAqaW1ncCkKICAgICB2bS0+dm1fYXNscl9kZWx0YV9zdGFjayA9IFBB WF9BU0xSX0RFTFRBKGFyYzRyYW5kb20oKSwKICAgICAgICAgUEFYX0FTTFJfREVMVEFfU1RBQ0tf TFNCLCAocHIgIT0gTlVMTCkgPyBwci0+cHJfcGF4X2FzbHJfc3RhY2tfbGVuIDogcGF4X2FzbHJf c3RhY2tfbGVuKTsKICAgICB2bS0+dm1fYXNscl9kZWx0YV9zdGFjayA9IEFMSUdOKHZtLT52bV9h c2xyX2RlbHRhX3N0YWNrKTsKLSAgICB2bS0+dm1fYXNscl9kZWx0YV9leGVjID0gcm91bmRfcGFn ZShQQVhfQVNMUl9ERUxUQShhcmM0cmFuZG9tKCksIFBBWF9BU0xSX0RFTFRBX0VYRUNfTFNCLCAo cHIgIT0gTlVMTCkgPyBwci0+cHJfcGF4X2FzbHJfZXhlY19sZW4gOiBwYXhfYXNscl9leGVjX2xl bikpOwogI2Vsc2UgLyogQ09NUEFUX0ZSRUVCU0QzMiAqLwogICAgIGlmICgoc3ZfZmxhZ3MgJiBT Vl9MUDY0KSAhPSAwKSB7CiAgICAgICAgIHZtLT52bV9hc2xyX2RlbHRhX21tYXAgPSBQQVhfQVNM Ul9ERUxUQShhcmM0cmFuZG9tKCksCg== --047d7bf15fde744b4b04f2019fcf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADt0fhxP1m4GocFh=hCawjSym0Gxw2DpwSsjbqUd4H_UkqZ4JA>