Date: Tue, 29 Apr 2003 16:08:59 -0400 (EDT) From: Andrew Gallatin <gallatin@cs.duke.edu> To: "M. Warner Losh" <imp@bsdimp.com> Cc: jhb@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <16046.56283.631906.102138@grasshopper.cs.duke.edu> In-Reply-To: <20030429.135157.94399579.imp@bsdimp.com> References: <16046.51947.425815.273156@grasshopper.cs.duke.edu> <XFMail.20030429152414.jhb@FreeBSD.org> <20030429.135157.94399579.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh writes: > > Comments? Mostly OK by me, except for the // style comments. Also, I'm not sure that checking for mutex_owned in the ioctl function is right. Picture ifconfig'ing an interface down (or starting tcpdump) while you're undergoing a DOS attach. Can you check for suspened instead? I'd still like to wrangle a generic, safe way of detaching interfaces out of John though ;) Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16046.56283.631906.102138>