From owner-cvs-ports@FreeBSD.ORG Sun May 1 02:59:14 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5445106566C; Sun, 1 May 2011 02:59:14 +0000 (UTC) (envelope-from inyaoo@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id DA6AD8FC1B; Sun, 1 May 2011 02:59:13 +0000 (UTC) Received: by eyg7 with SMTP id 7so1852661eyg.13 for ; Sat, 30 Apr 2011 19:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=vNqJGDeEYQHqLqz0mdRipcnq0ybD62NN9AZwuI4Zjcc=; b=YtEED4x2C+JvvLafT0jG2+WqFI5onOlgDnB6NaR4RFd4d54h1e0lZIjT9VcnwnXPHI OVmuVrezqVsU/15sIdRAIkLa105WwmB0R/e9J58z69AR0ubuQHx5wwKxdoG0e6nwvbtk 0aZiB4E8mUYJtHSfxnKLk+t7Hd6E36EO0nsbs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; b=eHWZYczTcnPGuxrnQ4WH+pvb86Yl2A74D7vbYc6ggebCVMGxc5HT72/2OKliBrPq+W 7dJGTLVrnrEfP630dBj16qv73QYS49T/ogrwmhGt7YMjWqX5u3uPJ+qhTebDFXpLZi4Y AAlEXH75LnALuzebXfrNQ3mdE9B20Nl1/w13M= Received: by 10.14.0.148 with SMTP id 20mr1443664eeb.0.1304218752622; Sat, 30 Apr 2011 19:59:12 -0700 (PDT) Received: from localhost (morales.torservers.net [195.60.76.241]) by mx.google.com with ESMTPS id g1sm1531892een.17.2011.04.30.19.59.08 (version=SSLv3 cipher=OTHER); Sat, 30 Apr 2011 19:59:10 -0700 (PDT) From: Pan Tsu To: ashish@freebsd.org (Ashish SHUKLA) In-Reply-To: <86pqo3mhbu.fsf@chateau.d.if> (Ashish SHUKLA's message of "Sun, 01 May 2011 05:18:21 +0530") References: <201104281508.p3SF8PjS068074@repoman.freebsd.org> <86tydfnbem.fsf@gmail.com> <86pqo3mhbu.fsf@chateau.d.if> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) Date: Sun, 01 May 2011 06:59:03 +0400 Message-ID: <86iptv15zc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/editors/emacs-devel Makefile distinfo ports/editors/emacs-devel/files patch-Makefile.in patch-configure patch-configure.in patch-doc-emacs-Makefile.in patch-doc-lispintro-Makefile.in patch-doc-lispref-Makefile.in patch-doc-misc-Makefile.in patch-src_config.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 02:59:14 -0000 ashish@freebsd.org (Ashish SHUKLA) writes: > Pan Tsu writes: >> - Any reason to use autogen.sh instead of relying on AUTOTOOLS? > > Because autogen.sh works fine, and is provided by the upstream to configure > the sources. So, I prefer to use upstream, unless it behaves badly. It makes sure autotools use and dependencies are tracked properly by the ports framework. For example, autoreconf (from autogen.sh) invokes autoheader which you did not specify in AUTOTOOLS. >> - Why patch-src_config.in was lost and not converted to patch-configure.in? > > As I see, in src/config.in (excerpt is pasted below) which get generated > already includes "stdlib.h", so I don't see any need of the re-including it, > unless you think it causes some issue. Including stdlib.h makes sure both alloca(3) and _STDLIB_H_ are defined at that point and no prior or future explicit inclusion of stdlib.h redefines it. The warning described ports/149049 is still present $ make gcc46 -DHAVE_CONFIG_H -I. -I../src -I/work/emacs-24.0.50.104000/src -I/usr/local/include -O2 -pipe -fno-strict-aliasing -MT mktime.o -MD -MP -MF .deps/mktime.Tpo -c -o mktime.o mktime.c In file included from mktime.c:25:0: ../src/config.h:1355:0: warning: "alloca" redefined [enabled by default] /usr/local/lib/gcc46/gcc/x86_64-portbld-freebsd9.0/4.6.1/include-fixed/stdlib.h:250:0: note: this is the location of the previous definition mv -f .deps/mktime.Tpo .deps/mktime.P and stems from... > > --8<---------------cut here---------------start------------->8--- > /* Define if the compiler supports function prototypes. It may do so but > not define __STDC__ (e.g. DEC C by default) or may define it as zero. */ > #undef PROTOTYPES > > #include > #include > > #ifdef HAVE_ALLOCA_H > # include > #elif defined __FreeBSD__ > #include > #elif defined __GNUC__ > # define alloca __builtin_alloca this definition for gcc/clang/pcc/etc. > #elif defined _AIX > # define alloca __alloca > #else > # include > # ifdef __cplusplus > extern "C" > # endif > void *alloca (size_t); > #endif > --8<---------------cut here---------------end--------------->8--- As HAVE_STDLIB_H is gone since r101711 HAVE_ALLOCA_H can be completely ignored on FreeBSD. %% Index: editors/emacs-devel/files/patch-configure.in =================================================================== RCS file: /a/.cvsup/ports/editors/emacs-devel/files/patch-configure.in,v retrieving revision 1.6 diff -u -p -r1.6 patch-configure.in --- editors/emacs-devel/files/patch-configure.in 28 Apr 2011 15:08:25 -0000 1.6 +++ editors/emacs-devel/files/patch-configure.in 1 May 2011 02:50:27 -0000 @@ -44,3 +44,20 @@ $FreeBSD: ports/editors/emacs-devel/file case "$opsys" in dnl defined __FreeBSD__ || defined __NetBSD__ || defined __linux__ gnu-linux|freebsd|netbsd) +@@ -3550,6 +3550,7 @@ + #include + #include + ++#ifndef __FreeBSD__ + #ifdef HAVE_ALLOCA_H + # include + #elif defined __GNUC__ +@@ -3563,6 +3564,7 @@ + # endif + void *alloca (size_t); + #endif ++#endif + + #ifndef HAVE_STRCHR + #define strchr(a, b) index (a, b) + %%