Date: Mon, 23 Feb 2004 18:07:29 +0100 From: Max Laier <max@love2party.net> To: Alexander Motin <mav@alkar.net>, freebsd-net@freebsd.org, freebsd-ipfw@freebsd.org Subject: Re: Generating 'Fragment Needed but DF was Set' ICMP & Dummynet Message-ID: <200402231807.29317.max@love2party.net> In-Reply-To: <c1d9id$10qf$1@pandora.alkar.net> References: <c0soic$1njq$2@pandora.alkar.net.lucky.freebsd.net> <c1d9id$10qf$1@pandora.alkar.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 23 February 2004 17:25, Alexander Motin wrote: > Here are my patches for this problem for FreeBSD 4.8 and 5.2. > Review them please. Looks good, though you might want to make sure to update statistics=20 (ipstat.ips_cantfrag++). And maybe lose the type and code vars - you=20 don't really use them: =2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0typ= e =3D ICMP_UNREACH; =2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0 =A0code =3D IC= MP_UNREACH_HOST; =2D=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0icm= p_error(mcopy, type, code, 0, pkt->ifp); + icmp_error(mcopy, ICMP_UNREACH, ICMP_UNREACH_HOST, + 0, pkt->ifp); Also note that this patch will require some work after the MT_TAG remove=20 http://people.freebsd.org/~mlaier/mt_tag_remove.diff as pkt is freed with=20 the mbuf. I'll keep it in mind. =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402231807.29317.max>