From owner-freebsd-stable@FreeBSD.ORG Fri Jan 21 10:41:17 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 018471065693; Fri, 21 Jan 2011 10:41:17 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 73B2D8FC17; Fri, 21 Jan 2011 10:41:15 +0000 (UTC) Received: by qyk8 with SMTP id 8so330548qyk.13 for ; Fri, 21 Jan 2011 02:41:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=kDy86W+XRs5ucbm7/q8WS0SehppGlGVQC6GTwv4Z9i0=; b=n+FUjIqM0xzB6nVbTaCHgkAxJ+mVpVkhLMTxl5FPChfBWLQbwyKKT3RA9AnQZCJOoH imA+wW/BuwM8et05fXH34YRHr4oZQgtzzCf8/dWThdCMoA4zG4wYFC7T++XJmAc0KQUg wpVMCGd4i8Xmf6lxaBZ9C4OjDrhJxKU7PKkZw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=wxkJANZI2htkXZQGk0ac6v70MIAIdvs2C4wMQMwJSyACgnOi/YZb+3/sEUIjDkQOyZ 5UogmkHB4pkmTTL7vH7B++6CPULYQ337Uj2or5JdfFv1PX4JPaOHt1cbhHwGg6x3WFhV 43HKjZaQl/p910P6reEo325JMShBC4AUjm2tk= MIME-Version: 1.0 Received: by 10.229.240.66 with SMTP id kz2mr430755qcb.233.1295606473953; Fri, 21 Jan 2011 02:41:13 -0800 (PST) Received: by 10.229.102.87 with HTTP; Fri, 21 Jan 2011 02:41:13 -0800 (PST) In-Reply-To: References: <4cfc72a5.3nAjkv8mdrO/NrKQ%perryh@pluto.rain.com> <4d3261bc.dcI6EuBnzRqvyRnz%perryh@pluto.rain.com> <201101181119.42053.jhb@freebsd.org> Date: Fri, 21 Jan 2011 13:41:13 +0300 Message-ID: From: Sergey Kandaurov To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: perryh@pluto.rain.com, freebsd-stable@freebsd.org, avg@freebsd.org Subject: Re: Could MSGBUF_SIZE be made a loader tunable? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2011 10:41:17 -0000 On 18 January 2011 20:51, Sergey Kandaurov wrote: > On 18 January 2011 19:19, John Baldwin wrote: >> On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote: >>> On 16 January 2011 06:10, =A0 wrote: >>> > Anyone had a chance to look at this? >>> > >>> > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/06079= 3.html >>> >>> To ease testing on head I have regenerated the patch >>> (against r216594): >>> http://plukky.net/~pluknet/patches/msgbufsize.diff >> >> The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrela= ted. > > Woops, sorry. Nice catch! > >> Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined >> and always assign it as the initial value rather than having an #ifdef. > Good. > >> Finally, I would adjust the wording in the manpage to not say that this >> modifies the MSGBUF_SIZE option, but that this tunable is the same as >> adjusting MSGBUF_SIZE. =A0Other than that I think it is fine. >> > > Right. I think a simple s/Modifies/Overrides/ here will be enough. > > Thanks for your valuable comments. > An updated patch is there: http://plukky.net/~pluknet/patches/msgbufsize.= 2.diff > I'm going to commit this soon. > Committed in r217688. --=20 wbr, pluknet