Date: Thu, 22 Nov 2001 17:45:52 +0900 From: Keiichi SHIMA / =?ISO-2022-JP?B?GyRCRWc3RDBsGyhC?= <keiichi@iij.ad.jp> To: freebsd-stable@FreeBSD.ORG Subject: if_fxp.c typo? Message-ID: <86y9kzqjlr.wl@keiichi01.osaka.iij.ad.jp>
next in thread | raw e-mail | index | archive | help
Hi all, fxp_stop() of the latest fxp driver do SOFTWARE_RESET when called. Shouldn't this be SELECTIVE_RESET? As I'm not familiar with fxp, would someone check and commit it to the repositry? The current code clears all the hardware mc filters already set, as a result, the box can't receive any multicast packets (this is a serious problem especially when using ipv6). --- Keiichi SHIMA IIJ Research Laboratory <keiichi@iij.ad.jp> KAME Project <keiichi@kame.net> --- orig/if_fxp.c Thu Nov 8 18:30:10 2001 +++ if_fxp.c Thu Nov 22 17:22:38 2001 @@ -1429,7 +1429,7 @@ * Issue software reset, which also unloads the microcode. */ sc->flags &= ~FXP_FLAG_UCODE; - CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SOFTWARE_RESET); + CSR_WRITE_4(sc, FXP_CSR_PORT, FXP_PORT_SELECTIVE_RESET); DELAY(50); /* To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86y9kzqjlr.wl>